* [Qemu-devel] [PATCH] isapc: Remove unnecessary migration compatibility code
@ 2017-10-06 13:25 Eduardo Habkost
2017-10-10 11:42 ` Igor Mammedov
0 siblings, 1 reply; 3+ messages in thread
From: Eduardo Habkost @ 2017-10-06 13:25 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini, Michael S. Tsirkin, Igor Mammedov
We don't touch isapc when we change guest ABI and add new entries
to PC_COMPAT_* or new PCMachineClass compat flags. This means
isapc never guaranteed guest ABI and cross-QEMU-version live
migration compatibility. There's no point in keeping code for
kvm-pv-eoi and APIC ID compatibility in pc_init_isa().
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
hw/i386/pc_piix.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index 9ff79b1fd9..31646e63c4 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -378,8 +378,6 @@ static void pc_compat_0_13(MachineState *machine)
static void pc_init_isa(MachineState *machine)
{
- x86_cpu_change_kvm_default("kvm-pv-eoi", NULL);
- enable_compat_apic_id_mode();
pc_init1(machine, TYPE_I440FX_PCI_HOST_BRIDGE, TYPE_I440FX_PCI_DEVICE);
}
--
2.13.6
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] isapc: Remove unnecessary migration compatibility code
2017-10-06 13:25 [Qemu-devel] [PATCH] isapc: Remove unnecessary migration compatibility code Eduardo Habkost
@ 2017-10-10 11:42 ` Igor Mammedov
2017-10-10 17:53 ` Eduardo Habkost
0 siblings, 1 reply; 3+ messages in thread
From: Igor Mammedov @ 2017-10-10 11:42 UTC (permalink / raw)
To: Eduardo Habkost; +Cc: qemu-devel, Paolo Bonzini, Michael S. Tsirkin
On Fri, 6 Oct 2017 10:25:02 -0300
Eduardo Habkost <ehabkost@redhat.com> wrote:
> We don't touch isapc when we change guest ABI and add new entries
> to PC_COMPAT_* or new PCMachineClass compat flags. This means
> isapc never guaranteed guest ABI and cross-QEMU-version live
> migration compatibility. There's no point in keeping code for
> kvm-pv-eoi and APIC ID compatibility in pc_init_isa().
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> hw/i386/pc_piix.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
> index 9ff79b1fd9..31646e63c4 100644
> --- a/hw/i386/pc_piix.c
> +++ b/hw/i386/pc_piix.c
> @@ -378,8 +378,6 @@ static void pc_compat_0_13(MachineState *machine)
>
> static void pc_init_isa(MachineState *machine)
> {
> - x86_cpu_change_kvm_default("kvm-pv-eoi", NULL);
> - enable_compat_apic_id_mode();
> pc_init1(machine, TYPE_I440FX_PCI_HOST_BRIDGE, TYPE_I440FX_PCI_DEVICE);
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] isapc: Remove unnecessary migration compatibility code
2017-10-10 11:42 ` Igor Mammedov
@ 2017-10-10 17:53 ` Eduardo Habkost
0 siblings, 0 replies; 3+ messages in thread
From: Eduardo Habkost @ 2017-10-10 17:53 UTC (permalink / raw)
To: Igor Mammedov; +Cc: qemu-devel, Paolo Bonzini, Michael S. Tsirkin
On Tue, Oct 10, 2017 at 01:42:04PM +0200, Igor Mammedov wrote:
> On Fri, 6 Oct 2017 10:25:02 -0300
> Eduardo Habkost <ehabkost@redhat.com> wrote:
>
> > We don't touch isapc when we change guest ABI and add new entries
> > to PC_COMPAT_* or new PCMachineClass compat flags. This means
> > isapc never guaranteed guest ABI and cross-QEMU-version live
> > migration compatibility. There's no point in keeping code for
> > kvm-pv-eoi and APIC ID compatibility in pc_init_isa().
> >
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Thanks!
Michael, do you prefer those pc*.c patches that touch only
CPU-related code to go always through your tree, or can I merge
them through x86-next without your Acked-by if it's appropriate?
>
> > ---
> > hw/i386/pc_piix.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
> > index 9ff79b1fd9..31646e63c4 100644
> > --- a/hw/i386/pc_piix.c
> > +++ b/hw/i386/pc_piix.c
> > @@ -378,8 +378,6 @@ static void pc_compat_0_13(MachineState *machine)
> >
> > static void pc_init_isa(MachineState *machine)
> > {
> > - x86_cpu_change_kvm_default("kvm-pv-eoi", NULL);
> > - enable_compat_apic_id_mode();
> > pc_init1(machine, TYPE_I440FX_PCI_HOST_BRIDGE, TYPE_I440FX_PCI_DEVICE);
> > }
> >
>
--
Eduardo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-10 17:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-06 13:25 [Qemu-devel] [PATCH] isapc: Remove unnecessary migration compatibility code Eduardo Habkost
2017-10-10 11:42 ` Igor Mammedov
2017-10-10 17:53 ` Eduardo Habkost
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).