From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38577) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1z4K-00073S-OC for qemu-devel@nongnu.org; Tue, 10 Oct 2017 14:15:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e1z4F-0002GL-NK for qemu-devel@nongnu.org; Tue, 10 Oct 2017 14:15:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39464) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e1z4F-0002Fa-H4 for qemu-devel@nongnu.org; Tue, 10 Oct 2017 14:15:47 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B5F7750EE2 for ; Tue, 10 Oct 2017 18:15:45 +0000 (UTC) From: Juan Quintela Date: Tue, 10 Oct 2017 20:15:32 +0200 Message-Id: <20171010181542.24168-1-quintela@redhat.com> Subject: [Qemu-devel] [PATCH 00/10] Make xbzrle_cache_size a migration parameter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: dgilbert@redhat.com, lvivier@redhat.com, peterx@redhat.com Hi I started looking at xbzrle_cache_size and saw that it was not a parameter. How difficult could it be? HaHa - x-multifd-page-count and x-multifd-channels were not o migrate_test_apply - page_cache.c has parameters that were not used (max_item_age) - page cache types were random. Move almost all to int/size_t as appropiate - error handling was split in three functions: xbzrle_cache_resize cache_init qmp_set_cache_size Make some sense of it and use Error* - We pass one value to qmp_migrate_cache_size it asigned pow2log() of that value, and cache_init() used a power of two. Make sure that the value passed is right. - Now I am able to make xbzrle_cache_size a parameter!!!! - Now that I have arrived here, I tried to make the json types for migartion parameters the real ones instead of everything is an int64. I will be happy if libvirt people checked this. Please review, Juan. Juan Quintela (10): migration: Fix migrate_test_apply for multifd parameters migratiom: Remove max_item_age parameter migration: Make cache size elements use the right types migration: Move xbzrle cache resize error handling to xbzrle_cache_resize migration: Make cache_init() take an error parameter migration: Make sure that we pass the right cache size migration: Don't play games with the requested cache size migration: No need to return the size of the cache migration: Make xbzrle_cache_size a migration parameter migration: [RFC] Use proper types in json hmp.c | 34 ++++++++++----- migration/migration.c | 112 ++++++++++++++++++++++++------------------------- migration/migration.h | 1 - migration/page_cache.c | 41 ++++++++++-------- migration/page_cache.h | 7 ++-- migration/ram.c | 36 ++++++++-------- migration/ram.h | 2 +- qapi/migration.json | 41 ++++++++++++------ 8 files changed, 155 insertions(+), 119 deletions(-) -- 2.13.6