From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, "Emilio G. Cota" <cota@braap.org>
Subject: [Qemu-devel] [PULL v2 12/20] exec-all: introduce TB_PAGE_ADDR_FMT
Date: Tue, 10 Oct 2017 12:29:55 -0700 [thread overview]
Message-ID: <20171010193003.28857-13-richard.henderson@linaro.org> (raw)
In-Reply-To: <20171010193003.28857-1-richard.henderson@linaro.org>
From: "Emilio G. Cota" <cota@braap.org>
And fix the following warning when DEBUG_TB_INVALIDATE is enabled
in translate-all.c:
CC mipsn32-linux-user/accel/tcg/translate-all.o
/data/src/qemu/accel/tcg/translate-all.c: In function ‘tb_alloc_page’:
/data/src/qemu/accel/tcg/translate-all.c:1201:16: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 2 has type ‘tb_page_addr_t {aka unsigned int}’ [-Werror=format=]
printf("protecting code page: 0x" TARGET_FMT_lx "\n",
^
cc1: all warnings being treated as errors
/data/src/qemu/rules.mak:66: recipe for target 'accel/tcg/translate-all.o' failed
make[1]: *** [accel/tcg/translate-all.o] Error 1
Makefile:328: recipe for target 'subdir-mipsn32-linux-user' failed
make: *** [subdir-mipsn32-linux-user] Error 2
cota@flamenco:/data/src/qemu/build ((18f3fe1...) *$)$
Reviewed-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Emilio G. Cota <cota@braap.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
include/exec/exec-all.h | 2 ++
accel/tcg/translate-all.c | 3 +--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h
index 3135aaf4c9..79f8041811 100644
--- a/include/exec/exec-all.h
+++ b/include/exec/exec-all.h
@@ -31,8 +31,10 @@
type. */
#if defined(CONFIG_USER_ONLY)
typedef abi_ulong tb_page_addr_t;
+#define TB_PAGE_ADDR_FMT TARGET_ABI_FMT_lx
#else
typedef ram_addr_t tb_page_addr_t;
+#define TB_PAGE_ADDR_FMT RAM_ADDR_FMT
#endif
#include "qemu/log.h"
diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c
index 799b027e79..90b3eed9c6 100644
--- a/accel/tcg/translate-all.c
+++ b/accel/tcg/translate-all.c
@@ -1193,8 +1193,7 @@ static inline void tb_alloc_page(TranslationBlock *tb,
mprotect(g2h(page_addr), qemu_host_page_size,
(prot & PAGE_BITS) & ~PAGE_WRITE);
#ifdef DEBUG_TB_INVALIDATE
- printf("protecting code page: 0x" TARGET_FMT_lx "\n",
- page_addr);
+ printf("protecting code page: 0x" TB_PAGE_ADDR_FMT "\n", page_addr);
#endif
}
#else
--
2.13.6
next prev parent reply other threads:[~2017-10-10 19:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 19:29 [Qemu-devel] [PULL v2 00/20] Queued TCG patches Richard Henderson
2017-10-10 19:29 ` [Qemu-devel] [PULL v2 01/20] cputlb: bring back tlb_flush_count under !TLB_DEBUG Richard Henderson
2017-10-10 19:29 ` [Qemu-devel] [PULL v2 02/20] tcg: fix corruption of code_time profiling counter upon tb_flush Richard Henderson
2017-10-10 19:29 ` [Qemu-devel] [PULL v2 03/20] exec-all: fix typos in TranslationBlock's documentation Richard Henderson
2017-10-10 19:29 ` [Qemu-devel] [PULL v2 04/20] translate-all: make have_tb_lock static Richard Henderson
2017-10-10 19:29 ` [Qemu-devel] [PULL v2 05/20] cpu-exec: rename have_tb_lock to acquired_tb_lock in tb_find Richard Henderson
2017-10-10 19:29 ` [Qemu-devel] [PULL v2 06/20] tcg/i386: constify tcg_target_callee_save_regs Richard Henderson
2017-10-10 19:29 ` [Qemu-devel] [PULL v2 07/20] tcg/mips: " Richard Henderson
2017-10-10 19:29 ` [Qemu-devel] [PULL v2 08/20] tcg: remove addr argument from lookup_tb_ptr Richard Henderson
2017-10-10 19:29 ` [Qemu-devel] [PULL v2 09/20] tcg: consolidate TB lookups in tb_lookup__cpu_state Richard Henderson
2017-10-10 19:29 ` [Qemu-devel] [PULL v2 10/20] exec-all: bring tb->invalid into tb->cflags Richard Henderson
2017-10-10 19:29 ` [Qemu-devel] [PULL v2 11/20] translate-all: define and use DEBUG_TB_FLUSH_GATE Richard Henderson
2017-10-10 19:29 ` Richard Henderson [this message]
2017-10-10 19:29 ` [Qemu-devel] [PULL v2 13/20] translate-all: define and use DEBUG_TB_INVALIDATE_GATE Richard Henderson
2017-10-10 19:29 ` [Qemu-devel] [PULL v2 14/20] translate-all: define and use DEBUG_TB_CHECK_GATE Richard Henderson
2017-10-10 19:29 ` [Qemu-devel] [PULL v2 15/20] exec-all: extract tb->tc_* into a separate struct tc_tb Richard Henderson
2017-10-10 19:29 ` [Qemu-devel] [PULL v2 16/20] tci: move tci_regs to tcg_qemu_tb_exec's stack Richard Henderson
2017-10-10 19:30 ` [Qemu-devel] [PULL v2 17/20] tcg: take .helpers out of TCGContext Richard Henderson
2017-10-10 19:30 ` [Qemu-devel] [PULL v2 18/20] util: move qemu_real_host_page_size/mask to osdep.h Richard Henderson
2017-10-10 19:30 ` [Qemu-devel] [PULL v2 19/20] tcg: define TCG_HIGHWATER Richard Henderson
2017-10-10 19:30 ` [Qemu-devel] [PULL v2 20/20] tcg/mips: delete commented out extern keyword Richard Henderson
2017-10-11 0:22 ` [Qemu-devel] [PULL v2 00/20] Queued TCG patches no-reply
2017-10-11 12:06 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171010193003.28857-13-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=cota@braap.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).