From: "Daniel P. Berrange" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] io: fix mem leak in websock error path
Date: Wed, 11 Oct 2017 16:38:43 +0100 [thread overview]
Message-ID: <20171011153843.9876-1-berrange@redhat.com> (raw)
Coverity pointed out the 'date' is not free()d in the error
path
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
io/channel-websock.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/io/channel-websock.c b/io/channel-websock.c
index aa35ef3274..a1c10ab719 100644
--- a/io/channel-websock.c
+++ b/io/channel-websock.c
@@ -355,6 +355,7 @@ static void qio_channel_websock_handshake_send_res_ok(QIOChannelWebsock *ioc,
QIO_CHANNEL_WEBSOCK_GUID_LEN,
&accept,
errp) < 0) {
+ g_free(date);
qio_channel_websock_handshake_send_res_err(
ioc, QIO_CHANNEL_WEBSOCK_HANDSHAKE_RES_SERVER_ERR);
return;
--
2.13.5
next reply other threads:[~2017-10-11 15:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 15:38 Daniel P. Berrange [this message]
2017-10-11 16:38 ` [Qemu-devel] [PATCH] io: fix mem leak in websock error path Eric Blake
2017-10-11 17:29 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171011153843.9876-1-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).