qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, kwolf@redhat.com, famz@redhat.com,
	jsnow@redhat.com, Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH v4 19/20] vvfat: Switch to .bdrv_co_block_status()
Date: Thu, 12 Oct 2017 13:59:15 -0500	[thread overview]
Message-ID: <20171012185916.22776-20-eblake@redhat.com> (raw)
In-Reply-To: <20171012185916.22776-1-eblake@redhat.com>

We are gradually moving away from sector-based interfaces, towards
byte-based.  Update the vvfat driver accordingly.  Note that we
can rely on the block driver having already clamped limits to our
block size, and simplify accordingly.

Signed-off-by: Eric Blake <eblake@redhat.com>

---
v4: rebase to interface tweak
v3: no change
v2: rebase to earlier changes, simplify
---
 block/vvfat.c | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/block/vvfat.c b/block/vvfat.c
index a0f2335894..9142117fc6 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -3082,15 +3082,13 @@ vvfat_co_pwritev(BlockDriverState *bs, uint64_t offset, uint64_t bytes,
     return ret;
 }

-static int64_t coroutine_fn vvfat_co_get_block_status(BlockDriverState *bs,
-        int64_t sector_num, int nb_sectors, int *n, BlockDriverState **file)
+static int coroutine_fn vvfat_co_block_status(BlockDriverState *bs,
+                                              bool want_zero, int64_t offset,
+                                              int64_t bytes, int64_t *n,
+                                              int64_t *map,
+                                              BlockDriverState **file)
 {
-    *n = bs->total_sectors - sector_num;
-    if (*n > nb_sectors) {
-        *n = nb_sectors;
-    } else if (*n < 0) {
-        return 0;
-    }
+    *n = bytes;
     return BDRV_BLOCK_DATA;
 }

@@ -3251,7 +3249,7 @@ static BlockDriver bdrv_vvfat = {

     .bdrv_co_preadv         = vvfat_co_preadv,
     .bdrv_co_pwritev        = vvfat_co_pwritev,
-    .bdrv_co_get_block_status = vvfat_co_get_block_status,
+    .bdrv_co_block_status   = vvfat_co_block_status,
 };

 static void bdrv_vvfat_init(void)
-- 
2.13.6

  parent reply	other threads:[~2017-10-12 19:06 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-12 18:58 [Qemu-devel] [PATCH v4 00/20] add byte-based block_status driver callbacks Eric Blake
2017-10-12 18:58 ` [Qemu-devel] [PATCH v4 01/20] block: Add .bdrv_co_block_status() callback Eric Blake
2017-11-28  8:02   ` Vladimir Sementsov-Ogievskiy
2017-10-12 18:58 ` [Qemu-devel] [PATCH v4 02/20] block: Switch passthrough drivers to .bdrv_co_block_status() Eric Blake
2017-11-28  8:19   ` Vladimir Sementsov-Ogievskiy
2017-11-28 16:05     ` Eric Blake
2017-10-12 18:58 ` [Qemu-devel] [PATCH v4 03/20] file-posix: Switch " Eric Blake
2017-11-30  8:06   ` Vladimir Sementsov-Ogievskiy
2017-11-30 20:40   ` Eric Blake
2017-10-12 18:59 ` [Qemu-devel] [PATCH v4 04/20] gluster: " Eric Blake
2017-11-30  8:44   ` Vladimir Sementsov-Ogievskiy
2017-10-12 18:59 ` [Qemu-devel] [PATCH v4 05/20] iscsi: Switch cluster_sectors to byte-based Eric Blake
2017-10-18  9:20   ` Paolo Bonzini
2017-10-12 18:59 ` [Qemu-devel] [PATCH v4 06/20] iscsi: Switch iscsi_allocmap_update() " Eric Blake
2017-10-18  9:20   ` Paolo Bonzini
2017-10-12 18:59 ` [Qemu-devel] [PATCH v4 07/20] iscsi: Switch to .bdrv_co_block_status() Eric Blake
2017-10-18  9:20   ` Paolo Bonzini
2017-10-12 18:59 ` [Qemu-devel] [PATCH v4 08/20] null: " Eric Blake
2017-11-30  8:47   ` Vladimir Sementsov-Ogievskiy
2017-10-12 18:59 ` [Qemu-devel] [PATCH v4 09/20] parallels: " Eric Blake
2017-11-30  9:03   ` Vladimir Sementsov-Ogievskiy
2017-11-30 22:12     ` Eric Blake
2017-11-30 22:18       ` Eric Blake
2017-10-12 18:59 ` [Qemu-devel] [PATCH v4 10/20] qcow: " Eric Blake
2017-11-30  9:26   ` Vladimir Sementsov-Ogievskiy
2017-10-12 18:59 ` [Qemu-devel] [PATCH v4 11/20] qcow2: " Eric Blake
2017-11-30  9:51   ` Vladimir Sementsov-Ogievskiy
2017-11-30 22:38     ` Eric Blake
2017-10-12 18:59 ` [Qemu-devel] [PATCH v4 12/20] qed: " Eric Blake
2017-11-30 10:27   ` Vladimir Sementsov-Ogievskiy
2017-11-30 23:17     ` Eric Blake
2017-12-04  8:59       ` Vladimir Sementsov-Ogievskiy
2017-10-12 18:59 ` [Qemu-devel] [PATCH v4 13/20] raw: " Eric Blake
2017-11-30 11:10   ` Vladimir Sementsov-Ogievskiy
2017-10-12 18:59 ` [Qemu-devel] [PATCH v4 14/20] sheepdog: " Eric Blake
2017-11-30 11:13   ` Vladimir Sementsov-Ogievskiy
2017-10-12 18:59 ` [Qemu-devel] [PATCH v4 15/20] vdi: Avoid bitrot of debugging code Eric Blake
2017-11-30 11:17   ` Vladimir Sementsov-Ogievskiy
2017-10-12 18:59 ` [Qemu-devel] [PATCH v4 16/20] vdi: Switch to .bdrv_co_block_status() Eric Blake
2017-11-30 11:26   ` Vladimir Sementsov-Ogievskiy
2017-11-30 23:11     ` Eric Blake
2017-10-12 18:59 ` [Qemu-devel] [PATCH v4 17/20] vmdk: " Eric Blake
2017-11-30 11:39   ` Vladimir Sementsov-Ogievskiy
2017-11-30 23:18     ` Eric Blake
2017-10-12 18:59 ` [Qemu-devel] [PATCH v4 18/20] vpc: " Eric Blake
2017-11-30 12:22   ` Vladimir Sementsov-Ogievskiy
2017-11-30 23:28     ` Eric Blake
2017-10-12 18:59 ` Eric Blake [this message]
2017-11-30 12:25   ` [Qemu-devel] [PATCH v4 19/20] vvfat: " Vladimir Sementsov-Ogievskiy
2017-11-30 23:31     ` Eric Blake
2017-10-12 18:59 ` [Qemu-devel] [PATCH v4 20/20] block: Drop unused .bdrv_co_get_block_status() Eric Blake
2017-11-30 12:29   ` Vladimir Sementsov-Ogievskiy
2017-11-21 11:27 ` [Qemu-devel] [PATCH v4 00/20] add byte-based block_status driver callbacks Vladimir Sementsov-Ogievskiy
2017-11-21 12:28   ` Eric Blake
2017-11-30 13:04 ` Vladimir Sementsov-Ogievskiy
2017-11-30 15:36   ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171012185916.22776-20-eblake@redhat.com \
    --to=eblake@redhat.com \
    --cc=famz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).