* [Qemu-devel] [PATCH 0/2] MAINTAINERS: Two small fixes
@ 2017-10-13 1:24 Fam Zheng
2017-10-13 1:24 ` [Qemu-devel] [PATCH 1/2] MAINTAINERS: Fix scsi path Fam Zheng
2017-10-13 1:24 ` [Qemu-devel] [PATCH 2/2] MAINTAINERS: Drop Sun4v nonexistent file Fam Zheng
0 siblings, 2 replies; 9+ messages in thread
From: Fam Zheng @ 2017-10-13 1:24 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial
Fam Zheng (2):
MAINTAINERS: Fix scsi path
MAINTAINERS: Drop Sun4v nonexistent file
MAINTAINERS | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--
2.13.5
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Qemu-devel] [PATCH 1/2] MAINTAINERS: Fix scsi path
2017-10-13 1:24 [Qemu-devel] [PATCH 0/2] MAINTAINERS: Two small fixes Fam Zheng
@ 2017-10-13 1:24 ` Fam Zheng
2017-10-13 8:04 ` Thomas Huth
2017-10-13 1:24 ` [Qemu-devel] [PATCH 2/2] MAINTAINERS: Drop Sun4v nonexistent file Fam Zheng
1 sibling, 1 reply; 9+ messages in thread
From: Fam Zheng @ 2017-10-13 1:24 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial
Signed-off-by: Fam Zheng <famz@redhat.com>
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 772ac209e1..da3c78df47 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -982,7 +982,7 @@ S: Supported
F: include/hw/scsi/*
F: include/scsi/*
F: hw/scsi/*
-F: util/scsi*
+F: scsi/*
F: tests/virtio-scsi-test.c
T: git git://github.com/bonzini/qemu.git scsi-next
--
2.13.5
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Qemu-devel] [PATCH 2/2] MAINTAINERS: Drop Sun4v nonexistent file
2017-10-13 1:24 [Qemu-devel] [PATCH 0/2] MAINTAINERS: Two small fixes Fam Zheng
2017-10-13 1:24 ` [Qemu-devel] [PATCH 1/2] MAINTAINERS: Fix scsi path Fam Zheng
@ 2017-10-13 1:24 ` Fam Zheng
2017-10-13 8:08 ` Thomas Huth
1 sibling, 1 reply; 9+ messages in thread
From: Fam Zheng @ 2017-10-13 1:24 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial
Signed-off-by: Fam Zheng <famz@redhat.com>
---
MAINTAINERS | 1 -
1 file changed, 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index da3c78df47..731c5c7ec2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -778,7 +778,6 @@ F: pc-bios/openbios-sparc64
Sun4v
M: Artyom Tarasenko <atar4qemu@gmail.com>
S: Maintained
-F: hw/sparc64/sun4v.c
F: hw/timer/sun4v-rtc.c
F: include/hw/timer/sun4v-rtc.h
--
2.13.5
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [PATCH 1/2] MAINTAINERS: Fix scsi path
2017-10-13 1:24 ` [Qemu-devel] [PATCH 1/2] MAINTAINERS: Fix scsi path Fam Zheng
@ 2017-10-13 8:04 ` Thomas Huth
2017-10-13 8:20 ` Fam Zheng
0 siblings, 1 reply; 9+ messages in thread
From: Thomas Huth @ 2017-10-13 8:04 UTC (permalink / raw)
To: Fam Zheng, qemu-devel; +Cc: qemu-trivial, Paolo Bonzini
On 13.10.2017 03:24, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> MAINTAINERS | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 772ac209e1..da3c78df47 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -982,7 +982,7 @@ S: Supported
> F: include/hw/scsi/*
> F: include/scsi/*
> F: hw/scsi/*
> -F: util/scsi*
> +F: scsi/*
scsi/* is already covered by the new "Block SCSI subsystem" section, so
I think you can also simply remove that line instead.
Thomas
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [PATCH 2/2] MAINTAINERS: Drop Sun4v nonexistent file
2017-10-13 1:24 ` [Qemu-devel] [PATCH 2/2] MAINTAINERS: Drop Sun4v nonexistent file Fam Zheng
@ 2017-10-13 8:08 ` Thomas Huth
2017-10-13 8:17 ` Artyom Tarasenko
0 siblings, 1 reply; 9+ messages in thread
From: Thomas Huth @ 2017-10-13 8:08 UTC (permalink / raw)
To: Fam Zheng, qemu-devel; +Cc: qemu-trivial, Artyom Tarasenko
On 13.10.2017 03:24, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> MAINTAINERS | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index da3c78df47..731c5c7ec2 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -778,7 +778,6 @@ F: pc-bios/openbios-sparc64
> Sun4v
> M: Artyom Tarasenko <atar4qemu@gmail.com>
> S: Maintained
> -F: hw/sparc64/sun4v.c
I guess you should rather replace that one with:
hw/sparc64/niagara.c
Artyom, is that right?
Thomas
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [PATCH 2/2] MAINTAINERS: Drop Sun4v nonexistent file
2017-10-13 8:08 ` Thomas Huth
@ 2017-10-13 8:17 ` Artyom Tarasenko
0 siblings, 0 replies; 9+ messages in thread
From: Artyom Tarasenko @ 2017-10-13 8:17 UTC (permalink / raw)
To: Thomas Huth; +Cc: Fam Zheng, qemu-devel, qemu-trivial
On Fri, Oct 13, 2017 at 10:08 AM, Thomas Huth <thuth@redhat.com> wrote:
> On 13.10.2017 03:24, Fam Zheng wrote:
>> Signed-off-by: Fam Zheng <famz@redhat.com>
>> ---
>> MAINTAINERS | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index da3c78df47..731c5c7ec2 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -778,7 +778,6 @@ F: pc-bios/openbios-sparc64
>> Sun4v
>> M: Artyom Tarasenko <atar4qemu@gmail.com>
>> S: Maintained
>> -F: hw/sparc64/sun4v.c
>
> I guess you should rather replace that one with:
>
> hw/sparc64/niagara.c
>
> Artyom, is that right?
Yes, please.
Thanks!
--
Regards,
Artyom Tarasenko
SPARC and PPC PReP under qemu blog: http://tyom.blogspot.com/search/label/qemu
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [PATCH 1/2] MAINTAINERS: Fix scsi path
2017-10-13 8:04 ` Thomas Huth
@ 2017-10-13 8:20 ` Fam Zheng
2017-10-13 8:30 ` Thomas Huth
0 siblings, 1 reply; 9+ messages in thread
From: Fam Zheng @ 2017-10-13 8:20 UTC (permalink / raw)
To: Thomas Huth; +Cc: qemu-devel, qemu-trivial, Paolo Bonzini
On Fri, 10/13 10:04, Thomas Huth wrote:
> On 13.10.2017 03:24, Fam Zheng wrote:
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > ---
> > MAINTAINERS | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 772ac209e1..da3c78df47 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -982,7 +982,7 @@ S: Supported
> > F: include/hw/scsi/*
> > F: include/scsi/*
> > F: hw/scsi/*
> > -F: util/scsi*
> > +F: scsi/*
>
> scsi/* is already covered by the new "Block SCSI subsystem" section, so
> I think you can also simply remove that line instead.
I didn't notice that section existing, should the two be merged into one?
Fam
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [PATCH 1/2] MAINTAINERS: Fix scsi path
2017-10-13 8:20 ` Fam Zheng
@ 2017-10-13 8:30 ` Thomas Huth
2017-10-13 8:45 ` Fam Zheng
0 siblings, 1 reply; 9+ messages in thread
From: Thomas Huth @ 2017-10-13 8:30 UTC (permalink / raw)
To: Fam Zheng; +Cc: qemu-devel, qemu-trivial, Paolo Bonzini
On 13.10.2017 10:20, Fam Zheng wrote:
> On Fri, 10/13 10:04, Thomas Huth wrote:
>> On 13.10.2017 03:24, Fam Zheng wrote:
>>> Signed-off-by: Fam Zheng <famz@redhat.com>
>>> ---
>>> MAINTAINERS | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index 772ac209e1..da3c78df47 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -982,7 +982,7 @@ S: Supported
>>> F: include/hw/scsi/*
>>> F: include/scsi/*
>>> F: hw/scsi/*
>>> -F: util/scsi*
>>> +F: scsi/*
>>
>> scsi/* is already covered by the new "Block SCSI subsystem" section, so
>> I think you can also simply remove that line instead.
>
> I didn't notice that section existing, should the two be merged into one?
I don't think so. One section is about the emulated SCSI devices, and
the other one about the SCSI block backend code, so that's two different
parts.
Some other ideas though:
1) I think "include/scsi/*" should be removed from the SCSI devices
section, it is already handled in the "Block SCSI subsystem" - and
headers that are related to devices should go into include/hw/scsi/
anyway instead.
2) The orphan LSI53C895A section could maybe be removed from the
MAINTAINERS file? It's of no use in its current "Orphan" state, and the
file is already covered by the generic SCSI devices section.
Thomas
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [PATCH 1/2] MAINTAINERS: Fix scsi path
2017-10-13 8:30 ` Thomas Huth
@ 2017-10-13 8:45 ` Fam Zheng
0 siblings, 0 replies; 9+ messages in thread
From: Fam Zheng @ 2017-10-13 8:45 UTC (permalink / raw)
To: Thomas Huth; +Cc: qemu-trivial, Paolo Bonzini, qemu-devel
On Fri, 10/13 10:30, Thomas Huth wrote:
> On 13.10.2017 10:20, Fam Zheng wrote:
> > On Fri, 10/13 10:04, Thomas Huth wrote:
> >> On 13.10.2017 03:24, Fam Zheng wrote:
> >>> Signed-off-by: Fam Zheng <famz@redhat.com>
> >>> ---
> >>> MAINTAINERS | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/MAINTAINERS b/MAINTAINERS
> >>> index 772ac209e1..da3c78df47 100644
> >>> --- a/MAINTAINERS
> >>> +++ b/MAINTAINERS
> >>> @@ -982,7 +982,7 @@ S: Supported
> >>> F: include/hw/scsi/*
> >>> F: include/scsi/*
> >>> F: hw/scsi/*
> >>> -F: util/scsi*
> >>> +F: scsi/*
> >>
> >> scsi/* is already covered by the new "Block SCSI subsystem" section, so
> >> I think you can also simply remove that line instead.
> >
> > I didn't notice that section existing, should the two be merged into one?
>
> I don't think so. One section is about the emulated SCSI devices, and
> the other one about the SCSI block backend code, so that's two different
> parts.
>
> Some other ideas though:
>
> 1) I think "include/scsi/*" should be removed from the SCSI devices
> section, it is already handled in the "Block SCSI subsystem" - and
> headers that are related to devices should go into include/hw/scsi/
> anyway instead.
>
> 2) The orphan LSI53C895A section could maybe be removed from the
> MAINTAINERS file? It's of no use in its current "Orphan" state, and the
> file is already covered by the generic SCSI devices section.
OK, that sounds good to me.
Fam
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-10-13 8:45 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-13 1:24 [Qemu-devel] [PATCH 0/2] MAINTAINERS: Two small fixes Fam Zheng
2017-10-13 1:24 ` [Qemu-devel] [PATCH 1/2] MAINTAINERS: Fix scsi path Fam Zheng
2017-10-13 8:04 ` Thomas Huth
2017-10-13 8:20 ` Fam Zheng
2017-10-13 8:30 ` Thomas Huth
2017-10-13 8:45 ` Fam Zheng
2017-10-13 1:24 ` [Qemu-devel] [PATCH 2/2] MAINTAINERS: Drop Sun4v nonexistent file Fam Zheng
2017-10-13 8:08 ` Thomas Huth
2017-10-13 8:17 ` Artyom Tarasenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).