qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Anthoine Bourgeois <anthoine.bourgeois@blade-group.com>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PULL 11/11] gtk: fix wrong id between texture and framebuffer
Date: Fri, 13 Oct 2017 10:14:50 +0200	[thread overview]
Message-ID: <20171013081450.29647-12-kraxel@redhat.com> (raw)
In-Reply-To: <20171013081450.29647-1-kraxel@redhat.com>

From: Anthoine Bourgeois <anthoine.bourgeois@blade-group.com>

The gd_gl_area_scanout_texture must destroy framebuffer if there is
no texture id instead of no framebuffer id.
The effect was a black screen with "-vga virtio -display gtk,gl=on"
options.
The bug was introduce by a4f113fd "gtk: use framebuffer helper functions."

Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@blade-group.com>
Message-id: 20171002124052.13829-1-anthoine.bourgeois@gmail.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 ui/gtk-gl-area.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c
index 01ebf2c7de..7080f4e14f 100644
--- a/ui/gtk-gl-area.c
+++ b/ui/gtk-gl-area.c
@@ -178,8 +178,7 @@ void gd_gl_area_scanout_texture(DisplayChangeListener *dcl,
 
     gtk_gl_area_make_current(GTK_GL_AREA(vc->gfx.drawing_area));
 
-    if (vc->gfx.guest_fb.framebuffer  == 0 ||
-        vc->gfx.w == 0 || vc->gfx.h == 0) {
+    if (backing_id == 0 || vc->gfx.w == 0 || vc->gfx.h == 0) {
         gtk_gl_area_set_scanout_mode(vc, false);
         return;
     }
-- 
2.9.3

  parent reply	other threads:[~2017-10-13  8:15 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-13  8:14 [Qemu-devel] [PULL 00/11] Ui 20171013 patches Gerd Hoffmann
2017-10-13  8:14 ` [Qemu-devel] [PULL 01/11] build: automatically handle GIT submodule checkout for dtc Gerd Hoffmann
2017-10-13  8:14 ` [Qemu-devel] [PULL 02/11] docker: don't rely on submodules existing in the main checkout Gerd Hoffmann
2017-10-13  8:14 ` [Qemu-devel] [PULL 03/11] ui: add keycodemapdb repository as a GIT submodule Gerd Hoffmann
2017-10-13  8:14 ` [Qemu-devel] [PULL 04/11] ui: convert common input code to keycodemapdb Gerd Hoffmann
2017-10-13  8:14 ` [Qemu-devel] [PULL 05/11] ui: convert key events to QKeyCodes immediately Gerd Hoffmann
2017-10-13  8:14 ` [Qemu-devel] [PULL 06/11] ui: don't export qemu_input_event_new_key Gerd Hoffmann
2017-10-13  8:14 ` [Qemu-devel] [PULL 07/11] tools: add qemu-keymap Gerd Hoffmann
2017-10-13  8:14 ` [Qemu-devel] [PULL 08/11] Add pc-bios/keymaps/Makefile Gerd Hoffmann
2017-10-13  8:14 ` [Qemu-devel] [PULL 09/11] pc-bios/keymaps: keymaps update Gerd Hoffmann
2017-10-13  8:14 ` [Qemu-devel] [PULL 10/11] ui/gtk: Fix deprecation of vte_terminal_copy_clipboard Gerd Hoffmann
2017-10-13  8:14 ` Gerd Hoffmann [this message]
2017-10-13  9:57 ` [Qemu-devel] [PULL 00/11] Ui 20171013 patches Daniel P. Berrange
2017-10-16  9:19   ` Gerd Hoffmann
2017-10-16 10:11     ` Daniel P. Berrange
  -- strict thread matches above, loose matches on Subject: below --
2017-10-16 13:16 [Qemu-devel] [PULL 00/11] Ui 20171016 patches Gerd Hoffmann
2017-10-16 13:16 ` [Qemu-devel] [PULL 11/11] gtk: fix wrong id between texture and framebuffer Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171013081450.29647-12-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=anthoine.bourgeois@blade-group.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).