qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-trivial@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] MAINTAINERS: Fix scsi path
Date: Fri, 13 Oct 2017 16:45:42 +0800	[thread overview]
Message-ID: <20171013084542.GB2756@lemon> (raw)
In-Reply-To: <048daae2-370a-e8cf-ef75-aee2e7a6508a@redhat.com>

On Fri, 10/13 10:30, Thomas Huth wrote:
> On 13.10.2017 10:20, Fam Zheng wrote:
> > On Fri, 10/13 10:04, Thomas Huth wrote:
> >> On 13.10.2017 03:24, Fam Zheng wrote:
> >>> Signed-off-by: Fam Zheng <famz@redhat.com>
> >>> ---
> >>>  MAINTAINERS | 2 +-
> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/MAINTAINERS b/MAINTAINERS
> >>> index 772ac209e1..da3c78df47 100644
> >>> --- a/MAINTAINERS
> >>> +++ b/MAINTAINERS
> >>> @@ -982,7 +982,7 @@ S: Supported
> >>>  F: include/hw/scsi/*
> >>>  F: include/scsi/*
> >>>  F: hw/scsi/*
> >>> -F: util/scsi*
> >>> +F: scsi/*
> >>
> >> scsi/* is already covered by the new "Block SCSI subsystem" section, so
> >> I think you can also simply remove that line instead.
> > 
> > I didn't notice that section existing, should the two be merged into one?
> 
> I don't think so. One section is about the emulated SCSI devices, and
> the other one about the SCSI block backend code, so that's two different
> parts.
> 
> Some other ideas though:
> 
> 1) I think "include/scsi/*" should be removed from the SCSI devices
> section, it is already handled in the "Block SCSI subsystem" - and
> headers that are related to devices should go into include/hw/scsi/
> anyway instead.
> 
> 2) The orphan LSI53C895A section could maybe be removed from the
> MAINTAINERS file? It's of no use in its current "Orphan" state, and the
> file is already covered by the generic SCSI devices section.

OK, that sounds good to me.

Fam

  reply	other threads:[~2017-10-13  8:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-13  1:24 [Qemu-devel] [PATCH 0/2] MAINTAINERS: Two small fixes Fam Zheng
2017-10-13  1:24 ` [Qemu-devel] [PATCH 1/2] MAINTAINERS: Fix scsi path Fam Zheng
2017-10-13  8:04   ` Thomas Huth
2017-10-13  8:20     ` Fam Zheng
2017-10-13  8:30       ` Thomas Huth
2017-10-13  8:45         ` Fam Zheng [this message]
2017-10-13  1:24 ` [Qemu-devel] [PATCH 2/2] MAINTAINERS: Drop Sun4v nonexistent file Fam Zheng
2017-10-13  8:08   ` Thomas Huth
2017-10-13  8:17     ` Artyom Tarasenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171013084542.GB2756@lemon \
    --to=famz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).