* [Qemu-devel] [PATCH] docker: Don't allocate tty unless DEBUG=1
@ 2017-10-13 1:19 Fam Zheng
2017-10-13 9:35 ` Alex Bennée
0 siblings, 1 reply; 3+ messages in thread
From: Fam Zheng @ 2017-10-13 1:19 UTC (permalink / raw)
To: qemu-devel
Cc: Eric Blake, Fam Zheng, Philippe Mathieu-Daudé,
Alex Bennée
The existence of tty in the container seems to urge gcc into colorize
the output, but the escape chars will clutter the report once turned
into email replies on patchew. Move -t to debug mode.
Reported-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
---
tests/docker/Makefile.include | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
index 6f9ea196a7..ab939f2bec 100644
--- a/tests/docker/Makefile.include
+++ b/tests/docker/Makefile.include
@@ -134,10 +134,10 @@ docker-run: docker-qemu-src
" COPYING $(EXECUTABLE) to $(IMAGE)"))
$(call quiet-command, \
$(SRC_PATH)/tests/docker/docker.py run \
- $(if $(NOUSER),,-u $(shell id -u)) -t \
+ $(if $(NOUSER),,-u $(shell id -u)) \
--security-opt seccomp=unconfined \
$(if $V,,--rm) \
- $(if $(DEBUG),-i,) \
+ $(if $(DEBUG),-ti,) \
$(if $(NETWORK),$(if $(subst $(NETWORK),,1),--net=$(NETWORK)),--net=none) \
-e TARGET_LIST=$(TARGET_LIST) \
-e EXTRA_CONFIGURE_OPTS="$(EXTRA_CONFIGURE_OPTS)" \
--
2.13.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] docker: Don't allocate tty unless DEBUG=1
2017-10-13 1:19 [Qemu-devel] [PATCH] docker: Don't allocate tty unless DEBUG=1 Fam Zheng
@ 2017-10-13 9:35 ` Alex Bennée
2017-10-13 9:46 ` Fam Zheng
0 siblings, 1 reply; 3+ messages in thread
From: Alex Bennée @ 2017-10-13 9:35 UTC (permalink / raw)
To: Fam Zheng; +Cc: qemu-devel, Eric Blake, Philippe Mathieu-Daudé
Fam Zheng <famz@redhat.com> writes:
> The existence of tty in the container seems to urge gcc into colorize
> the output, but the escape chars will clutter the report once turned
> into email replies on patchew. Move -t to debug mode.
>
> Reported-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Fam Zheng <famz@redhat.com>
I certainly improves my Emacs compilation-mode buffer when applied:
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> tests/docker/Makefile.include | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
> index 6f9ea196a7..ab939f2bec 100644
> --- a/tests/docker/Makefile.include
> +++ b/tests/docker/Makefile.include
> @@ -134,10 +134,10 @@ docker-run: docker-qemu-src
> " COPYING $(EXECUTABLE) to $(IMAGE)"))
> $(call quiet-command, \
> $(SRC_PATH)/tests/docker/docker.py run \
> - $(if $(NOUSER),,-u $(shell id -u)) -t \
> + $(if $(NOUSER),,-u $(shell id -u)) \
> --security-opt seccomp=unconfined \
> $(if $V,,--rm) \
> - $(if $(DEBUG),-i,) \
> + $(if $(DEBUG),-ti,) \
> $(if $(NETWORK),$(if $(subst $(NETWORK),,1),--net=$(NETWORK)),--net=none) \
> -e TARGET_LIST=$(TARGET_LIST) \
> -e EXTRA_CONFIGURE_OPTS="$(EXTRA_CONFIGURE_OPTS)" \
--
Alex Bennée
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] docker: Don't allocate tty unless DEBUG=1
2017-10-13 9:35 ` Alex Bennée
@ 2017-10-13 9:46 ` Fam Zheng
0 siblings, 0 replies; 3+ messages in thread
From: Fam Zheng @ 2017-10-13 9:46 UTC (permalink / raw)
To: Alex Bennée; +Cc: qemu-devel, Philippe Mathieu-Daudé
On Fri, 10/13 10:35, Alex Bennée wrote:
>
> Fam Zheng <famz@redhat.com> writes:
>
> > The existence of tty in the container seems to urge gcc into colorize
> > the output, but the escape chars will clutter the report once turned
> > into email replies on patchew. Move -t to debug mode.
> >
> > Reported-by: Eric Blake <eblake@redhat.com>
> > Signed-off-by: Fam Zheng <famz@redhat.com>
>
> I certainly improves my Emacs compilation-mode buffer when applied:
>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Nice, thanks! I'll send a pull request soon.
Fam
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-13 9:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-13 1:19 [Qemu-devel] [PATCH] docker: Don't allocate tty unless DEBUG=1 Fam Zheng
2017-10-13 9:35 ` Alex Bennée
2017-10-13 9:46 ` Fam Zheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).