From: Stefan Hajnoczi <stefanha@gmail.com>
To: Manos Pitsidianakis <el13635@mail.ntua.gr>
Cc: qemu-devel <qemu-devel@nongnu.org>, Kevin Wolf <kwolf@redhat.com>,
Fam Zheng <famz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-block <qemu-block@nongnu.org>, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v3 0/3] add bdrv_co_drain_begin/end BlockDriver callbacks
Date: Fri, 13 Oct 2017 13:27:25 +0100 [thread overview]
Message-ID: <20171013122725.GG27308@stefanha-x1.localdomain> (raw)
In-Reply-To: <20170923111411.18626-1-el13635@mail.ntua.gr>
On Sat, Sep 23, 2017 at 02:14:08PM +0300, Manos Pitsidianakis wrote:
> This patch series renames bdrv_co_drain to bdrv_co_drain_begin and adds a new
> bdrv_co_drain_end callback to match bdrv_drained_begin/end and
> drained_begin/end of BdrvChild. This is needed because the throttle driver
> (block/throttle.c) needs a way to mark the end of the drain in order to toggle
> io_limits_disabled correctly.
>
> Based-on: <20170918202529.28379-1-el13635@mail.ntua.gr>
> "block/throttle-groups.c: allocate RestartData on the heap"
> Which fixes a coroutine crash in block/throttle-groups.c
>
> v3:
> fixed commit message typo in first patch [Fam]
> rephrased doc comment based on mailing discussion
> v2:
> add doc for callbacks and change order of request polling for completion
> [Stefan]
>
> Manos Pitsidianakis (3):
> block: add bdrv_co_drain_end callback
> block: rename bdrv_co_drain to bdrv_co_drain_begin
> block/throttle.c: add bdrv_co_drain_begin/end callbacks
>
> include/block/block_int.h | 13 ++++++++++---
> block/io.c | 48 +++++++++++++++++++++++++++++++++--------------
> block/qed.c | 6 +++---
> block/throttle.c | 18 ++++++++++++++++++
> 4 files changed, 65 insertions(+), 20 deletions(-)
>
> --
> 2.11.0
>
>
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
prev parent reply other threads:[~2017-10-13 12:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-23 11:14 [Qemu-devel] [PATCH v3 0/3] add bdrv_co_drain_begin/end BlockDriver callbacks Manos Pitsidianakis
2017-09-23 11:14 ` [Qemu-devel] [PATCH v3 1/3] block: add bdrv_co_drain_end callback Manos Pitsidianakis
2017-09-25 2:27 ` Fam Zheng
2017-09-25 10:06 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-09-23 11:14 ` [Qemu-devel] [PATCH v3 2/3] block: rename bdrv_co_drain to bdrv_co_drain_begin Manos Pitsidianakis
2017-09-25 10:06 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-09-23 11:14 ` [Qemu-devel] [PATCH v3 3/3] block/throttle.c: add bdrv_co_drain_begin/end callbacks Manos Pitsidianakis
2017-09-26 10:02 ` [Qemu-devel] [PATCH v3 0/3] add bdrv_co_drain_begin/end BlockDriver callbacks Stefan Hajnoczi
2017-09-26 11:00 ` Stefan Hajnoczi
2017-09-26 12:44 ` Manos Pitsidianakis
2017-09-29 12:25 ` Kevin Wolf
2017-10-13 12:27 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171013122725.GG27308@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=el13635@mail.ntua.gr \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).