From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59035) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e35ap-0000wQ-6w for qemu-devel@nongnu.org; Fri, 13 Oct 2017 15:26:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e35am-0001z6-3i for qemu-devel@nongnu.org; Fri, 13 Oct 2017 15:25:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39838) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e35al-0001yO-Sz for qemu-devel@nongnu.org; Fri, 13 Oct 2017 15:25:56 -0400 Date: Fri, 13 Oct 2017 16:25:50 -0300 From: Eduardo Habkost Message-ID: <20171013192550.GC3246@localhost.localdomain> References: <20171012235439.19457-1-anatol.pomozov@gmail.com> <20171012235439.19457-3-anatol.pomozov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171012235439.19457-3-anatol.pomozov@gmail.com> Subject: Re: [Qemu-devel] [PATCH 2/4] multiboot: load any machine type of ELF List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anatol Pomozov Cc: qemu-devel@nongnu.org, kwolf@redhat.com, rth@twiddle.net, pbonzini@redhat.com, agraf@suse.de, "Michael S. Tsirkin" On Thu, Oct 12, 2017 at 04:54:37PM -0700, Anatol Pomozov wrote: > x86 is not the only architecture supported by multiboot. > For example GRUB supports MIPS architecture as well. > > Signed-off-by: Anatol Pomozov > --- > hw/i386/multiboot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/i386/multiboot.c b/hw/i386/multiboot.c > index c9254f313e..7dacd6d827 100644 > --- a/hw/i386/multiboot.c > +++ b/hw/i386/multiboot.c > @@ -173,7 +173,7 @@ int load_multiboot(FWCfgState *fw_cfg, > } > > kernel_size = load_elf(kernel_filename, NULL, NULL, &elf_entry, > - &elf_low, &elf_high, 0, I386_ELF_MACHINE, > + &elf_low, &elf_high, 0, EM_NONE, > 0, 0); I assume we still want PC to reject non-x86 ELF files. Isn't it better to add a elf_machine argument to load_multiboot() so each load_multiboot() caller can specify what's the expected architecture? > if (kernel_size < 0) { > fprintf(stderr, "Error while loading elf kernel\n"); > -- > 2.15.0.rc0.271.g36b669edcc-goog > -- Eduardo