From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: Andrea Arcangeli <aarcange@redhat.com>,
"Daniel P . Berrange" <berrange@redhat.com>,
Juan Quintela <quintela@redhat.com>,
Alexey Perevalov <a.perevalov@samsung.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
peterx@redhat.com
Subject: [Qemu-devel] [PATCH v3 31/32] migration, qmp: new command "migrate-pause"
Date: Mon, 16 Oct 2017 14:52:15 +0800 [thread overview]
Message-ID: <20171016065216.18162-32-peterx@redhat.com> (raw)
In-Reply-To: <20171016065216.18162-1-peterx@redhat.com>
It is used to manually trigger the postcopy pause state. It works just
like when we found the migration stream failed during postcopy, but
provide an explicit way for user in case of misterious socket hangs.
Signed-off-by: Peter Xu <peterx@redhat.com>
---
migration/migration.c | 18 ++++++++++++++++++
qapi/migration.json | 22 ++++++++++++++++++++++
2 files changed, 40 insertions(+)
diff --git a/migration/migration.c b/migration/migration.c
index 51e771685c..3d852d233f 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -1426,6 +1426,24 @@ void qmp_migrate_incoming(const char *uri, Error **errp)
once = false;
}
+void qmp_migrate_pause(Error **errp)
+{
+ int ret;
+ MigrationState *ms = migrate_get_current();
+
+ if (ms->state != MIGRATION_STATUS_POSTCOPY_ACTIVE) {
+ error_setg(errp, "Migration pause is currently only allowed during"
+ " an active postcopy phase.");
+ return;
+ }
+
+ ret = qemu_file_shutdown(ms->to_dst_file);
+
+ if (ret) {
+ error_setg(errp, "Failed to pause migration stream.");
+ }
+}
+
bool migration_is_blocked(Error **errp)
{
if (qemu_savevm_state_blocked(errp)) {
diff --git a/qapi/migration.json b/qapi/migration.json
index f8132e683a..095aeb4dd2 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@@ -1028,6 +1028,28 @@
{ 'command': 'migrate-incoming', 'data': {'uri': 'str' } }
##
+# @migrate-pause:
+#
+# Pause an migration. Currently it can only pause a postcopy
+# migration. Pausing a precopy migration is not supported yet.
+#
+# It is mostly used as a manual way to trigger the postcopy paused
+# state when the network sockets hang due to some reason, so that we
+# can try a recovery afterward.
+#
+# Returns: nothing on success
+#
+# Since: 2.10
+#
+# Example:
+#
+# -> { "execute": "migrate-pause" }
+# <- { "return": {} }
+#
+##
+{ 'command': 'migrate-pause' }
+
+##
# @xen-save-devices-state:
#
# Save the state of all devices to file. The RAM and the block devices
--
2.13.5
next prev parent reply other threads:[~2017-10-16 6:54 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 6:51 [Qemu-devel] [PATCH v3 00/32] Migration: postcopy failure recovery Peter Xu
2017-10-16 6:51 ` [Qemu-devel] [PATCH v3 01/32] migration: better error handling with QEMUFile Peter Xu
2017-10-16 6:51 ` [Qemu-devel] [PATCH v3 02/32] migration: reuse mis->userfault_quit_fd Peter Xu
2017-10-16 6:51 ` [Qemu-devel] [PATCH v3 03/32] migration: provide postcopy_fault_thread_notify() Peter Xu
2017-10-16 6:51 ` [Qemu-devel] [PATCH v3 04/32] migration: new postcopy-pause state Peter Xu
2017-10-16 6:51 ` [Qemu-devel] [PATCH v3 05/32] migration: implement "postcopy-pause" src logic Peter Xu
2017-10-16 6:51 ` [Qemu-devel] [PATCH v3 06/32] migration: allow dst vm pause on postcopy Peter Xu
2017-10-16 6:51 ` [Qemu-devel] [PATCH v3 07/32] migration: allow src return path to pause Peter Xu
2017-10-16 6:51 ` [Qemu-devel] [PATCH v3 08/32] migration: allow send_rq to fail Peter Xu
2017-10-16 6:51 ` [Qemu-devel] [PATCH v3 09/32] migration: allow fault thread to pause Peter Xu
2017-10-16 6:51 ` [Qemu-devel] [PATCH v3 10/32] qmp: hmp: add migrate "resume" option Peter Xu
2017-10-16 6:51 ` [Qemu-devel] [PATCH v3 11/32] migration: pass MigrationState to migrate_init() Peter Xu
2017-10-16 6:51 ` [Qemu-devel] [PATCH v3 12/32] migration: rebuild channel on source Peter Xu
2017-10-16 6:51 ` [Qemu-devel] [PATCH v3 13/32] migration: new state "postcopy-recover" Peter Xu
2017-10-16 6:51 ` [Qemu-devel] [PATCH v3 14/32] migration: wakeup dst ram-load-thread for recover Peter Xu
2017-10-16 6:51 ` [Qemu-devel] [PATCH v3 15/32] migration: new cmd MIG_CMD_RECV_BITMAP Peter Xu
2017-10-16 6:52 ` [Qemu-devel] [PATCH v3 16/32] migration: new message MIG_RP_MSG_RECV_BITMAP Peter Xu
2017-10-16 6:52 ` [Qemu-devel] [PATCH v3 17/32] migration: new cmd MIG_CMD_POSTCOPY_RESUME Peter Xu
2017-10-16 6:52 ` [Qemu-devel] [PATCH v3 18/32] migration: new message MIG_RP_MSG_RESUME_ACK Peter Xu
2017-10-16 6:52 ` [Qemu-devel] [PATCH v3 19/32] migration: introduce SaveVMHandlers.resume_prepare Peter Xu
2017-10-16 6:52 ` [Qemu-devel] [PATCH v3 20/32] migration: synchronize dirty bitmap for resume Peter Xu
2017-10-16 6:52 ` [Qemu-devel] [PATCH v3 21/32] migration: setup ramstate " Peter Xu
2017-10-16 6:52 ` [Qemu-devel] [PATCH v3 22/32] migration: final handshake for the resume Peter Xu
2017-10-16 6:52 ` [Qemu-devel] [PATCH v3 23/32] migration: free SocketAddress where allocated Peter Xu
2017-10-16 6:52 ` [Qemu-devel] [PATCH v3 24/32] migration: return incoming task tag for sockets Peter Xu
2017-10-16 6:52 ` [Qemu-devel] [PATCH v3 25/32] migration: return incoming task tag for exec Peter Xu
2017-10-16 6:52 ` [Qemu-devel] [PATCH v3 26/32] migration: return incoming task tag for fd Peter Xu
2017-10-16 6:52 ` [Qemu-devel] [PATCH v3 27/32] migration: store listen task tag Peter Xu
2017-10-16 6:52 ` [Qemu-devel] [PATCH v3 28/32] migration: allow migrate_incoming for paused VM Peter Xu
2017-10-16 6:52 ` [Qemu-devel] [PATCH v3 29/32] migration: init dst in migration_object_init too Peter Xu
2017-10-16 6:52 ` [Qemu-devel] [PATCH v3 30/32] migration: delay the postcopy-active state switch Peter Xu
2017-10-16 6:52 ` Peter Xu [this message]
2017-10-16 7:06 ` [Qemu-devel] [PATCH v3 31/32] migration, qmp: new command "migrate-pause" Peter Xu
2017-10-16 6:52 ` [Qemu-devel] [PATCH v3 32/32] migration, hmp: new command "migrate_pause" Peter Xu
2017-10-16 7:32 ` [Qemu-devel] [PATCH v3 00/32] Migration: postcopy failure recovery no-reply
2017-10-16 9:41 ` Peter Xu
2017-10-30 9:29 ` Juan Quintela
2017-10-16 8:05 ` no-reply
2017-10-16 9:43 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171016065216.18162-32-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=a.perevalov@samsung.com \
--cc=aarcange@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).