qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Joe Clifford <joeclifford@gmail.com>,
	David Hildenbrand <david@redhat.com>
Subject: [Qemu-devel] [PATCH v1 3/7] kvm: tolerate non-existing slot for log_start/log_stop/log_sync
Date: Mon, 16 Oct 2017 16:42:58 +0200	[thread overview]
Message-ID: <20171016144302.24284-4-david@redhat.com> (raw)
In-Reply-To: <20171016144302.24284-1-david@redhat.com>

If we want to trap every access to a section, we might not have a
slot. So let's just tolerate if we don't have one.

Signed-off-by: David Hildenbrand <david@redhat.com>
---
 accel/kvm/kvm-all.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index fae1eca983..f5fa3e24bd 100644
--- a/accel/kvm/kvm-all.c
+++ b/accel/kvm/kvm-all.c
@@ -394,8 +394,8 @@ static int kvm_section_update_flags(KVMMemoryListener *kml,
 
     mem = kvm_lookup_matching_slot(kml, start_addr, size);
     if (!mem) {
-        fprintf(stderr, "%s: error finding slot\n", __func__);
-        abort();
+        /* We don't have a slot if we want to trap every access. */
+        return 0;
     }
 
     return kvm_slot_update_flags(kml, mem, section->mr);
@@ -470,8 +470,8 @@ static int kvm_physical_sync_dirty_bitmap(KVMMemoryListener *kml,
     if (size) {
         mem = kvm_lookup_matching_slot(kml, start_addr, size);
         if (!mem) {
-            fprintf(stderr, "%s: error finding slot\n", __func__);
-            abort();
+            /* We don't have a slot if we want to trap every access. */
+            return 0;
         }
 
         /* XXX bad kernel interface alert
-- 
2.13.5

  parent reply	other threads:[~2017-10-16 14:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-16 14:42 [Qemu-devel] [PATCH v1 0/7] kvm: slot handling fixes (and small cleanups) David Hildenbrand
2017-10-16 14:42 ` [Qemu-devel] [PATCH v1 1/7] memory: call log_start after region_add David Hildenbrand
2017-10-16 14:42 ` [Qemu-devel] [PATCH v1 2/7] kvm: fix alignment of ram address David Hildenbrand
2017-10-16 14:42 ` David Hildenbrand [this message]
2017-10-16 14:42 ` [Qemu-devel] [PATCH v1 4/7] kvm: fix error message when failing to unregister slot David Hildenbrand
2017-10-16 14:43 ` [Qemu-devel] [PATCH v1 5/7] kvm: region_add and region_del is not called on updates David Hildenbrand
2017-10-16 14:43 ` [Qemu-devel] [PATCH v1 6/7] kvm: simplify kvm_align_section() David Hildenbrand
2017-10-16 14:43 ` [Qemu-devel] [PATCH v1 7/7] memory: reuse section_from_flat_range() David Hildenbrand
2017-10-16 16:20 ` [Qemu-devel] [PATCH v1 0/7] kvm: slot handling fixes (and small cleanups) Paolo Bonzini
2017-10-17  0:06   ` Joe Clifford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171016144302.24284-4-david@redhat.com \
    --to=david@redhat.com \
    --cc=joeclifford@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).