From: David Hildenbrand <david@redhat.com>
To: qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Joe Clifford <joeclifford@gmail.com>,
David Hildenbrand <david@redhat.com>
Subject: [Qemu-devel] [PATCH v1 6/7] kvm: simplify kvm_align_section()
Date: Mon, 16 Oct 2017 16:43:01 +0200 [thread overview]
Message-ID: <20171016144302.24284-7-david@redhat.com> (raw)
In-Reply-To: <20171016144302.24284-1-david@redhat.com>
Use ROUND_UP and simplify the code a bit.
Signed-off-by: David Hildenbrand <david@redhat.com>
---
accel/kvm/kvm-all.c | 18 ++++++------------
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index 2835bb3801..f290f487a5 100644
--- a/accel/kvm/kvm-all.c
+++ b/accel/kvm/kvm-all.c
@@ -197,26 +197,20 @@ static hwaddr kvm_align_section(MemoryRegionSection *section,
hwaddr *start)
{
hwaddr size = int128_get64(section->size);
- hwaddr delta;
-
- *start = section->offset_within_address_space;
+ hwaddr delta, aligned;
/* kvm works in page size chunks, but the function may be called
with sub-page size and unaligned start address. Pad the start
address to next and truncate size to previous page boundary. */
- delta = qemu_real_host_page_size - (*start & ~qemu_real_host_page_mask);
- delta &= ~qemu_real_host_page_mask;
- *start += delta;
+ aligned = ROUND_UP(section->offset_within_address_space,
+ qemu_real_host_page_size);
+ delta = aligned - section->offset_within_address_space;
+ *start = aligned;
if (delta > size) {
return 0;
}
- size -= delta;
- size &= qemu_real_host_page_mask;
- if (*start & ~qemu_real_host_page_mask) {
- return 0;
- }
- return size;
+ return (size - delta) & qemu_real_host_page_mask;
}
int kvm_physical_memory_addr_from_host(KVMState *s, void *ram,
--
2.13.5
next prev parent reply other threads:[~2017-10-16 14:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 14:42 [Qemu-devel] [PATCH v1 0/7] kvm: slot handling fixes (and small cleanups) David Hildenbrand
2017-10-16 14:42 ` [Qemu-devel] [PATCH v1 1/7] memory: call log_start after region_add David Hildenbrand
2017-10-16 14:42 ` [Qemu-devel] [PATCH v1 2/7] kvm: fix alignment of ram address David Hildenbrand
2017-10-16 14:42 ` [Qemu-devel] [PATCH v1 3/7] kvm: tolerate non-existing slot for log_start/log_stop/log_sync David Hildenbrand
2017-10-16 14:42 ` [Qemu-devel] [PATCH v1 4/7] kvm: fix error message when failing to unregister slot David Hildenbrand
2017-10-16 14:43 ` [Qemu-devel] [PATCH v1 5/7] kvm: region_add and region_del is not called on updates David Hildenbrand
2017-10-16 14:43 ` David Hildenbrand [this message]
2017-10-16 14:43 ` [Qemu-devel] [PATCH v1 7/7] memory: reuse section_from_flat_range() David Hildenbrand
2017-10-16 16:20 ` [Qemu-devel] [PATCH v1 0/7] kvm: slot handling fixes (and small cleanups) Paolo Bonzini
2017-10-17 0:06 ` Joe Clifford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171016144302.24284-7-david@redhat.com \
--to=david@redhat.com \
--cc=joeclifford@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).