From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36311) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e48GS-0000fi-9e for qemu-devel@nongnu.org; Mon, 16 Oct 2017 12:29:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e48GR-00030R-Am for qemu-devel@nongnu.org; Mon, 16 Oct 2017 12:29:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33584) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e48GR-0002yb-27 for qemu-devel@nongnu.org; Mon, 16 Oct 2017 12:29:15 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 20B1D12B6 for ; Mon, 16 Oct 2017 16:29:14 +0000 (UTC) Date: Mon, 16 Oct 2017 17:29:10 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20171016162910.GG2252@work-vm> References: <20171004103933.7898-1-quintela@redhat.com> <20171004103933.7898-6-quintela@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171004103933.7898-6-quintela@redhat.com> Subject: Re: [Qemu-devel] [PATCH 5/6] tests: Add migration compress threads tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org, lvivier@redhat.com, peterx@redhat.com * Juan Quintela (quintela@redhat.com) wrote: > For some reason, compression is not working at the moment, test is > disabled until I found why. > > Signed-off-by: Juan Quintela > --- > tests/migration-test.c | 51 ++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 51 insertions(+) > > diff --git a/tests/migration-test.c b/tests/migration-test.c > index f0734e4ba0..a8abc3d007 100644 > --- a/tests/migration-test.c > +++ b/tests/migration-test.c > @@ -621,6 +621,54 @@ static void test_xbzrle_unix(void) > g_free(uri); > } > > +static void test_compress(const char *uri) > +{ > + QTestState *from, *to; > + > + test_migrate_start(&from, &to, uri); > + > + /* We want to pick a speed slow enough that the test completes > + * quickly, but that it doesn't complete precopy even on a slow > + * machine, so also set the downtime. > + */ > + /* 100 ms */ > + migrate_set_parameter(from, "downtime-limit", "100"); > + /* 1MB/s slow*/ > + migrate_set_parameter(from, "max-bandwidth", "100000000"); > + > + migrate_set_parameter(from, "compress-threads", "4"); > + migrate_set_parameter(from, "decompress-threads", "3"); Should that be 'to' ? I worry about having this many threads in a loaded test environment. Dave > + migrate_set_capability(from, "compress", "true"); > + migrate_set_capability(to, "compress", "true"); > + /* Wait for the first serial output from the source */ > + wait_for_serial("src_serial"); > + > + migrate(from, uri); > + > + wait_for_migration_pass(from); > + > + /* 1GB/s now it should converge */ > + migrate_set_parameter(from, "max-bandwidth", "1000000000"); > + > + if (!got_stop) { > + qtest_qmp_eventwait(from, "STOP"); > + } > + qtest_qmp_eventwait(to, "RESUME"); > + > + wait_for_serial("dest_serial"); > + wait_for_migration_complete(from); > + > + test_migrate_end(from, to); > +} > + > +static void test_compress_unix(void) > +{ > + char *uri = g_strdup_printf("unix:%s/migsocket", tmpfs); > + > + test_compress(uri); > + g_free(uri); > +} > > int main(int argc, char **argv) > { > @@ -641,6 +689,9 @@ int main(int argc, char **argv) > qtest_add_func("/migration/precopy/tcp", test_precopy_tcp); > qtest_add_func("/migration/deprecated/unix", test_deprecated_unix); > qtest_add_func("/migration/xbzrle/unix", test_xbzrle_unix); > + if (0) { > + qtest_add_func("/migration/compress/unix", test_compress_unix); > + } > > ret = g_test_run(); > > -- > 2.13.5 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK