qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org, lvivier@redhat.com, peterx@redhat.com
Subject: Re: [Qemu-devel] [PATCH 6/6] tests: Move postcopy migration test to migrate-set-parameters
Date: Mon, 16 Oct 2017 17:31:36 +0100	[thread overview]
Message-ID: <20171016163135.GH2252@work-vm> (raw)
In-Reply-To: <20171004103933.7898-7-quintela@redhat.com>

* Juan Quintela (quintela@redhat.com) wrote:
> migrate_set_speed and migrate_set_dowtime are deprecated since long ago.
> 
> Signed-off-by: Juan Quintela <quintela@redhat.com>

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

> ---
>  tests/postcopy-test.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/postcopy-test.c b/tests/postcopy-test.c
> index 8142f2ab90..991b954a83 100644
> --- a/tests/postcopy-test.c
> +++ b/tests/postcopy-test.c
> @@ -430,14 +430,14 @@ static void test_migrate(void)
>       * machine, so also set the downtime.
>       */
>      global_qtest = from;
> -    rsp = qmp("{ 'execute': 'migrate_set_speed',"
> -              "'arguments': { 'value': 100000000 } }");
> +    rsp = qmp("{ 'execute': 'migrate-set-parameters',"
> +              "'arguments': { 'max-bandwidth': 100000000 } }");
>      g_assert(qdict_haskey(rsp, "return"));
>      QDECREF(rsp);
>  
>      /* 1ms downtime - it should never finish precopy */
> -    rsp = qmp("{ 'execute': 'migrate_set_downtime',"
> -              "'arguments': { 'value': 0.001 } }");
> +    rsp = qmp("{ 'execute': 'migrate-set-parameters',"
> +              "'arguments': { 'downtime-limit': 1 } }");
>      g_assert(qdict_haskey(rsp, "return"));
>      QDECREF(rsp);
>  
> -- 
> 2.13.5
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

  reply	other threads:[~2017-10-16 16:31 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-04 10:39 [Qemu-devel] [PATCH 0/6] Add make check tests for Migration Juan Quintela
2017-10-04 10:39 ` [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test Juan Quintela
2017-10-04 12:33   ` Thomas Huth
2017-10-04 12:46     ` Juan Quintela
2017-10-04 13:07       ` Thomas Huth
2017-10-04 15:52   ` Eric Blake
2017-10-09  8:19   ` Peter Xu
2017-10-18 11:49     ` Juan Quintela
2017-10-16 11:59   ` Dr. David Alan Gilbert
2017-10-18  4:26   ` Peter Xu
2017-10-18 11:36     ` Juan Quintela
2017-10-18 12:10       ` Daniel P. Berrange
2017-10-19  3:18         ` Peter Xu
2017-10-19  9:09           ` Daniel P. Berrange
2017-10-19  9:16             ` Dr. David Alan Gilbert
2017-10-19  9:19               ` Daniel P. Berrange
2017-10-19  9:23                 ` Dr. David Alan Gilbert
2017-10-19  9:09           ` Dr. David Alan Gilbert
2017-10-18 12:03   ` Daniel P. Berrange
2017-10-18 12:49     ` Dr. David Alan Gilbert
2017-10-18 13:08       ` Daniel P. Berrange
2017-10-04 10:39 ` [Qemu-devel] [PATCH 2/6] tests: Add basic migration precopy tcp test Juan Quintela
2017-10-16 12:09   ` Dr. David Alan Gilbert
2017-10-18 11:51     ` Juan Quintela
2017-10-04 10:39 ` [Qemu-devel] [PATCH 3/6] tests: Add precopy test using deprecated commands Juan Quintela
2017-10-16 15:40   ` Dr. David Alan Gilbert
2017-10-18 11:52     ` Juan Quintela
2017-10-04 10:39 ` [Qemu-devel] [PATCH 4/6] tests: Add migration xbzrle test Juan Quintela
2017-10-16 16:07   ` Dr. David Alan Gilbert
2017-10-18 11:56     ` Juan Quintela
2017-10-19  9:06       ` Dr. David Alan Gilbert
2017-10-04 10:39 ` [Qemu-devel] [PATCH 5/6] tests: Add migration compress threads tests Juan Quintela
2017-10-09  8:28   ` Peter Xu
2017-10-18 11:59     ` Juan Quintela
2017-10-16 16:29   ` Dr. David Alan Gilbert
2017-10-18 11:57     ` Juan Quintela
2017-10-04 10:39 ` [Qemu-devel] [PATCH 6/6] tests: Move postcopy migration test to migrate-set-parameters Juan Quintela
2017-10-16 16:31   ` Dr. David Alan Gilbert [this message]
2017-10-04 13:25 ` [Qemu-devel] [PATCH 0/6] Add make check tests for Migration no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171016163135.GH2252@work-vm \
    --to=dgilbert@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).