From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37192) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e48Iq-0002WY-EX for qemu-devel@nongnu.org; Mon, 16 Oct 2017 12:31:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e48In-0004HM-AD for qemu-devel@nongnu.org; Mon, 16 Oct 2017 12:31:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39628) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e48In-0004Gr-48 for qemu-devel@nongnu.org; Mon, 16 Oct 2017 12:31:41 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F06873DFCC for ; Mon, 16 Oct 2017 16:31:39 +0000 (UTC) Date: Mon, 16 Oct 2017 17:31:36 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20171016163135.GH2252@work-vm> References: <20171004103933.7898-1-quintela@redhat.com> <20171004103933.7898-7-quintela@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171004103933.7898-7-quintela@redhat.com> Subject: Re: [Qemu-devel] [PATCH 6/6] tests: Move postcopy migration test to migrate-set-parameters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org, lvivier@redhat.com, peterx@redhat.com * Juan Quintela (quintela@redhat.com) wrote: > migrate_set_speed and migrate_set_dowtime are deprecated since long ago. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > tests/postcopy-test.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tests/postcopy-test.c b/tests/postcopy-test.c > index 8142f2ab90..991b954a83 100644 > --- a/tests/postcopy-test.c > +++ b/tests/postcopy-test.c > @@ -430,14 +430,14 @@ static void test_migrate(void) > * machine, so also set the downtime. > */ > global_qtest = from; > - rsp = qmp("{ 'execute': 'migrate_set_speed'," > - "'arguments': { 'value': 100000000 } }"); > + rsp = qmp("{ 'execute': 'migrate-set-parameters'," > + "'arguments': { 'max-bandwidth': 100000000 } }"); > g_assert(qdict_haskey(rsp, "return")); > QDECREF(rsp); > > /* 1ms downtime - it should never finish precopy */ > - rsp = qmp("{ 'execute': 'migrate_set_downtime'," > - "'arguments': { 'value': 0.001 } }"); > + rsp = qmp("{ 'execute': 'migrate-set-parameters'," > + "'arguments': { 'downtime-limit': 1 } }"); > g_assert(qdict_haskey(rsp, "return")); > QDECREF(rsp); > > -- > 2.13.5 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK