* [Qemu-devel] [PATCH] docker: cleanup temp directory after test
@ 2017-10-17 7:12 Peter Xu
2017-10-17 8:12 ` Fam Zheng
2017-10-18 7:31 ` Fam Zheng
0 siblings, 2 replies; 3+ messages in thread
From: Peter Xu @ 2017-10-17 7:12 UTC (permalink / raw)
To: qemu-devel
Cc: peterx, Alex Bennée, Fam Zheng, Philippe Mathieu-Daudé
There are temp directories named "docker-src.*" after doing docker
tests. I don't see much point in keeping that (it only contains the
qemu.tar which is exactly current tree, and the copied "run" file).
Let's remove it after test finished.
CC: "Alex Bennée" <alex.bennee@linaro.org>
CC: Fam Zheng <famz@redhat.com>
CC: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
tests/docker/Makefile.include | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
index 6f9ea196a7..c8fbd37127 100644
--- a/tests/docker/Makefile.include
+++ b/tests/docker/Makefile.include
@@ -151,6 +151,8 @@ docker-run: docker-qemu-src
$(IMAGE) \
/var/tmp/qemu/run \
$(TEST), " RUN $(TEST) in ${IMAGE}")
+ $(call quiet-command, rm -r $(DOCKER_SRC_COPY), \
+ " CLEANUP $(DOCKER_SRC_COPY)")
# Run targets:
#
--
2.13.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] docker: cleanup temp directory after test
2017-10-17 7:12 [Qemu-devel] [PATCH] docker: cleanup temp directory after test Peter Xu
@ 2017-10-17 8:12 ` Fam Zheng
2017-10-18 7:31 ` Fam Zheng
1 sibling, 0 replies; 3+ messages in thread
From: Fam Zheng @ 2017-10-17 8:12 UTC (permalink / raw)
To: Peter Xu; +Cc: qemu-devel, Alex Bennée, Philippe Mathieu-Daudé
On Tue, 10/17 15:12, Peter Xu wrote:
> There are temp directories named "docker-src.*" after doing docker
> tests. I don't see much point in keeping that (it only contains the
> qemu.tar which is exactly current tree, and the copied "run" file).
> Let's remove it after test finished.
>
> CC: "Alex Bennée" <alex.bennee@linaro.org>
> CC: Fam Zheng <famz@redhat.com>
> CC: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> tests/docker/Makefile.include | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
> index 6f9ea196a7..c8fbd37127 100644
> --- a/tests/docker/Makefile.include
> +++ b/tests/docker/Makefile.include
> @@ -151,6 +151,8 @@ docker-run: docker-qemu-src
> $(IMAGE) \
> /var/tmp/qemu/run \
> $(TEST), " RUN $(TEST) in ${IMAGE}")
> + $(call quiet-command, rm -r $(DOCKER_SRC_COPY), \
> + " CLEANUP $(DOCKER_SRC_COPY)")
>
> # Run targets:
> #
> --
> 2.13.5
>
>
Reviewed-by: Fam Zheng <famz@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] docker: cleanup temp directory after test
2017-10-17 7:12 [Qemu-devel] [PATCH] docker: cleanup temp directory after test Peter Xu
2017-10-17 8:12 ` Fam Zheng
@ 2017-10-18 7:31 ` Fam Zheng
1 sibling, 0 replies; 3+ messages in thread
From: Fam Zheng @ 2017-10-18 7:31 UTC (permalink / raw)
To: Peter Xu; +Cc: qemu-devel, Alex Bennée, Philippe Mathieu-Daudé
On Tue, 10/17 15:12, Peter Xu wrote:
> There are temp directories named "docker-src.*" after doing docker
> tests. I don't see much point in keeping that (it only contains the
> qemu.tar which is exactly current tree, and the copied "run" file).
> Let's remove it after test finished.
>
> CC: "Alex Bennée" <alex.bennee@linaro.org>
> CC: Fam Zheng <famz@redhat.com>
> CC: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> tests/docker/Makefile.include | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
> index 6f9ea196a7..c8fbd37127 100644
> --- a/tests/docker/Makefile.include
> +++ b/tests/docker/Makefile.include
> @@ -151,6 +151,8 @@ docker-run: docker-qemu-src
> $(IMAGE) \
> /var/tmp/qemu/run \
> $(TEST), " RUN $(TEST) in ${IMAGE}")
> + $(call quiet-command, rm -r $(DOCKER_SRC_COPY), \
> + " CLEANUP $(DOCKER_SRC_COPY)")
>
> # Run targets:
> #
> --
> 2.13.5
>
>
Applied, thanks!
Fam
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-18 7:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-17 7:12 [Qemu-devel] [PATCH] docker: cleanup temp directory after test Peter Xu
2017-10-17 8:12 ` Fam Zheng
2017-10-18 7:31 ` Fam Zheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).