From: Halil Pasic <pasic@linux.vnet.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>,
Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>
Cc: Thomas Huth <thuth@redhat.com>,
Pierre Morel <pmorel@linux.vnet.ibm.com>,
qemu-devel@nongnu.org, Halil Pasic <pasic@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH v3 0/7] improve error handling for IO instr
Date: Tue, 17 Oct 2017 16:04:46 +0200 [thread overview]
Message-ID: <20171017140453.51099-1-pasic@linux.vnet.ibm.com> (raw)
Abstract
=======
The basic idea is: tell how to handle an unusual condition where it's
identified, instead of mapping it to an errno (more or less arbitrarily),
then possibly mapping these errnos around, to finally (mentally) map the
errno back to the condition and take appropriate action.
According to Dong Jia the patch-set also has a functional value: for ccw
pass-through, he is planing to pass-through the instruction completion
information (cc or interruption condition) from the kernel, and this
patch set can pretty much be seen as a preparation for that.
Changelog
=========
Patch 1 should be already applied to Conny's tree. I've included it
nevertheless so guys working on top of current master have everything in
place.
v2 -> v3:
* somewhat uwillingly traded the type safe struct to a somewhat
type safe enum (because considered ugly) (Thomas, Conny)
* dropped 'template approach' patch which intended to further
consolidate IO inst. handlers having lot's of logic and code in
common (Conny)
* added warning if vfio-ccw ORB does not have the flags required
by the vfio-ccw implementation as suggested (Dong Jia)
* got rid of some unintentional changes (Dong Jia)
* reworded some stuff (comments, commit messages) (Dong Jia)
v1 -> v2:
* use assert if do_subchannel_work without any functions being
accepted
* generate unit-exception if ccw-vfio can't handle an otherwise
good channel program (due to extra limitations)
* keep using return values opposed to recording into SubchDev
* split out 'add infrastructure' from 'refactor first handler'
* reworded some commit messanges and comments
* rebased on top of current master
* dropped r-b's and acks because of the magnitude of the
changes
Testing
=======
Nothing happened since v2 except for a quick smoke test. Dong Jia gave v2
a spin with a focus on vfio-ccw. @Dong Jia I would appreciate some proper
testing, especially regarding the changes in vfio-ccw (patch #3).
Halil Pasic (7):
s390x/css: be more consistent if broken beyond repair
s390x/css: IO instr handler ending control
s390x: improve error handling for SSCH and RSCH
s390x: refactor error handling for XSCH handler
s390x: refactor error handling for CSCH handler
s390x: refactor error handling for HSCH handler
s390x: refactor error handling for MSCH handler
hw/s390x/css.c | 163 ++++++++++++--------------------------------
hw/s390x/s390-ccw.c | 11 ++-
hw/vfio/ccw.c | 28 ++++++--
include/hw/s390x/css.h | 47 ++++++++++---
include/hw/s390x/s390-ccw.h | 2 +-
target/s390x/ioinst.c | 136 +++++++-----------------------------
6 files changed, 132 insertions(+), 255 deletions(-)
--
2.13.5
next reply other threads:[~2017-10-17 14:05 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 14:04 Halil Pasic [this message]
2017-10-17 14:04 ` [Qemu-devel] [PATCH v3 1/7] s390x/css: be more consistent if broken beyond repair Halil Pasic
2017-10-18 8:13 ` Thomas Huth
2017-10-17 14:04 ` [Qemu-devel] [PATCH v3 2/7] s390x/css: IO instr handler ending control Halil Pasic
2017-10-17 14:58 ` Cornelia Huck
2017-10-17 16:13 ` Halil Pasic
2017-10-18 8:45 ` Thomas Huth
2017-10-18 9:34 ` Cornelia Huck
2017-10-18 9:13 ` Dong Jia Shi
2017-10-17 14:04 ` [Qemu-devel] [PATCH v3 3/7] s390x: improve error handling for SSCH and RSCH Halil Pasic
2017-10-17 15:06 ` Cornelia Huck
2017-10-18 9:30 ` Thomas Huth
2017-10-18 9:52 ` Thomas Huth
2017-10-18 9:58 ` Cornelia Huck
2017-10-18 10:02 ` Thomas Huth
2017-10-18 9:52 ` Cornelia Huck
2017-10-18 10:07 ` Thomas Huth
2017-10-18 11:07 ` Halil Pasic
2017-10-18 11:12 ` Thomas Huth
2017-10-18 11:17 ` Halil Pasic
2017-10-19 6:06 ` Dong Jia Shi
2017-10-17 14:04 ` [Qemu-devel] [PATCH v3 4/7] s390x: refactor error handling for XSCH handler Halil Pasic
2017-10-17 15:07 ` Cornelia Huck
2017-10-18 9:33 ` Thomas Huth
2017-10-19 6:11 ` Dong Jia Shi
2017-10-19 9:10 ` Halil Pasic
2017-10-17 14:04 ` [Qemu-devel] [PATCH v3 5/7] s390x: refactor error handling for CSCH handler Halil Pasic
2017-10-17 15:09 ` Cornelia Huck
2017-10-18 9:36 ` Thomas Huth
2017-10-19 6:14 ` Dong Jia Shi
2017-10-19 9:11 ` Cornelia Huck
2017-10-17 14:04 ` [Qemu-devel] [PATCH v3 6/7] s390x: refactor error handling for HSCH handler Halil Pasic
2017-10-17 15:10 ` Cornelia Huck
2017-10-18 9:55 ` Thomas Huth
2017-10-19 6:17 ` Dong Jia Shi
2017-10-17 14:04 ` [Qemu-devel] [PATCH v3 7/7] s390x: refactor error handling for MSCH handler Halil Pasic
2017-10-17 15:11 ` Cornelia Huck
2017-10-18 10:00 ` Thomas Huth
2017-10-18 10:02 ` Cornelia Huck
2017-10-18 11:01 ` Halil Pasic
2017-10-19 6:23 ` Dong Jia Shi
2017-10-17 15:13 ` [Qemu-devel] [PATCH v3 0/7] improve error handling for IO instr Cornelia Huck
2017-10-17 16:19 ` Halil Pasic
2017-10-18 7:38 ` Cornelia Huck
2017-10-18 8:23 ` Dong Jia Shi
2017-10-18 9:53 ` Cornelia Huck
2017-10-19 6:01 ` Dong Jia Shi
2017-10-18 12:50 ` Cornelia Huck
2017-10-19 10:46 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171017140453.51099-1-pasic@linux.vnet.ibm.com \
--to=pasic@linux.vnet.ibm.com \
--cc=bjsdjshi@linux.vnet.ibm.com \
--cc=cohuck@redhat.com \
--cc=pmorel@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).