qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: pkrempa@redhat.com, mreitz@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/1] qemu-iotests: Test backing_fmt with backing node reference
Date: Tue, 17 Oct 2017 17:16:58 +0200	[thread overview]
Message-ID: <20171017151658.GD7660@dhcp-200-186.str.redhat.com> (raw)
In-Reply-To: <20171017151149.28062-1-kwolf@redhat.com>

Am 17.10.2017 um 17:11 hat Kevin Wolf geschrieben:
> This changes test case 191 to include a backing image that has
> backing_fmt set in the image file, but is referenced by node name in the
> qemu command line.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  tests/qemu-iotests/191     | 5 +++--
>  tests/qemu-iotests/191.out | 2 +-
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/qemu-iotests/191 b/tests/qemu-iotests/191
> index ac2b88fd78..00202efd47 100755
> --- a/tests/qemu-iotests/191
> +++ b/tests/qemu-iotests/191
> @@ -56,9 +56,10 @@ echo === Preparing and starting VM ===
>  echo
>  
>  TEST_IMG="${TEST_IMG}.base" _make_test_img $size
> -TEST_IMG="${TEST_IMG}.mid" _make_test_img -b "${TEST_IMG}.base"
> +IMGOPTS=$(_optstr_add "$IMGOPTS" "backing_fmt=$IMGFMT") \
> +    TEST_IMG="${TEST_IMG}.mid" _make_test_img -b "${TEST_IMG}.base" $size
>  _make_test_img -b "${TEST_IMG}.mid"
> -TEST_IMG="${TEST_IMG}.ovl2" _make_test_img -b "${TEST_IMG}.mid"
> +TEST_IMG="${TEST_IMG}.ovl2" _make_test_img -b "${TEST_IMG}.mid" $size

Please pretend you don't see the addition of " $size" here, it's
unnecessary and I'll remove it again.

Kevin

  reply	other threads:[~2017-10-17 15:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-12 14:14 [Qemu-devel] [PATCH] block: don't add 'driver' to options when refering to backing via node name Peter Krempa
2017-10-17 14:41 ` Kevin Wolf
2017-10-17 14:44   ` Peter Krempa
2017-10-17 15:11 ` [Qemu-devel] [PATCH 2/1] qemu-iotests: Test backing_fmt with backing node reference Kevin Wolf
2017-10-17 15:16   ` Kevin Wolf [this message]
2017-10-17 21:44     ` Eric Blake
2017-10-17 21:41 ` [Qemu-devel] [PATCH] block: don't add 'driver' to options when refering to backing via node name Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171017151658.GD7660@dhcp-200-186.str.redhat.com \
    --to=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pkrempa@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).