From: Riku Voipio <riku.voipio@iki.fi>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org, Laurent Vivier <laurent@vivier.eu>
Subject: Re: [Qemu-devel] [PATCH] linux-user/main: support dfilter
Date: Tue, 17 Oct 2017 19:18:00 +0000 [thread overview]
Message-ID: <20171017191800.GA16659@kos.to> (raw)
In-Reply-To: <20171017103514.5859-1-alex.bennee@linaro.org>
On Tue, Oct 17, 2017 at 11:35:14AM +0100, Alex Bennée wrote:
> This adds the -dfilter support to linux-user. There is a minor
> checkpatch complaint about formatting which I've ignored for aesthetic
> reasons.
Applied to linux-user, thanks
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>
> ---
> v2
> - add r-b tags
> - expand comment to mention checkpatch failure
> ---
> linux-user/main.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/linux-user/main.c b/linux-user/main.c
> index 829f974662..5072aa855b 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -3854,6 +3854,11 @@ static void handle_arg_log(const char *arg)
> qemu_set_log(mask);
> }
>
> +static void handle_arg_dfilter(const char *arg)
> +{
> + qemu_set_dfilter_ranges(arg, NULL);
> +}
> +
> static void handle_arg_log_filename(const char *arg)
> {
> qemu_set_log_filename(arg, &error_fatal);
> @@ -4054,6 +4059,8 @@ static const struct qemu_argument arg_table[] = {
> {"d", "QEMU_LOG", true, handle_arg_log,
> "item[,...]", "enable logging of specified items "
> "(use '-d help' for a list of items)"},
> + {"dfilter", "QEMU_DFILTER", true, handle_arg_dfilter,
> + "range[,...]","filter logging based on address range"},
> {"D", "QEMU_LOG_FILENAME", true, handle_arg_log_filename,
> "logfile", "write logs to 'logfile' (default stderr)"},
> {"p", "QEMU_PAGESIZE", true, handle_arg_pagesize,
> --
> 2.14.1
>
prev parent reply other threads:[~2017-10-17 19:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 10:35 [Qemu-devel] [PATCH] linux-user/main: support dfilter Alex Bennée
2017-10-17 11:11 ` no-reply
2017-10-17 19:18 ` Riku Voipio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171017191800.GA16659@kos.to \
--to=riku.voipio@iki.fi \
--cc=alex.bennee@linaro.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).