From: Igor Mammedov <imammedo@redhat.com>
To: Alistair Francis <alistair.francis@xilinx.com>
Cc: qemu-devel@nongnu.org, ehabkost@redhat.com, f4bug@amsat.org,
marcel@redhat.com, alistair23@gmail.com
Subject: Re: [Qemu-devel] [PATCH v3 2/5] bcm2836: Use the Cortex-A7 instead of Cortex-A15
Date: Wed, 18 Oct 2017 09:48:17 +0200 [thread overview]
Message-ID: <20171018094817.3fef3d8d@nial.brq.redhat.com> (raw)
In-Reply-To: <ef4e172df6cdf3d9ee8bb3aa896cacab5efdd1f1.1508279421.git.alistair.francis@xilinx.com>
On Tue, 17 Oct 2017 15:31:14 -0700
Alistair Francis <alistair.francis@xilinx.com> wrote:
> The BCM2836 uses a Cortex-A7 not a Cortex-A15. Update the device to use
> the correct CPU.
> https://www.raspberrypi.org/documentation/hardware/raspberrypi/bcm2836/QA7_rev3.4.pdf
>
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> V3:
> - Use ARM_CPU_TYPE_NAME() macro
> V2:
> - Fix the BCM2836 CPU
>
> hw/arm/bcm2836.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/bcm2836.c b/hw/arm/bcm2836.c
> index 8c43291112..c477772484 100644
> --- a/hw/arm/bcm2836.c
> +++ b/hw/arm/bcm2836.c
> @@ -30,7 +30,7 @@ static void bcm2836_init(Object *obj)
>
> for (n = 0; n < BCM2836_NCPUS; n++) {
> object_initialize(&s->cpus[n], sizeof(s->cpus[n]),
> - "cortex-a15-" TYPE_ARM_CPU);
> + ARM_CPU_TYPE_NAME("cortex-a7"));
> object_property_add_child(obj, "cpu[*]", OBJECT(&s->cpus[n]),
> &error_abort);
> }
next prev parent reply other threads:[~2017-10-18 7:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 22:31 [Qemu-devel] [PATCH v3 0/5] Add a valid_cpu_types property Alistair Francis
2017-10-17 22:31 ` [Qemu-devel] [PATCH v3 1/5] netduino2: Specify the valid CPUs Alistair Francis
2017-10-17 22:31 ` [Qemu-devel] [PATCH v3 2/5] bcm2836: Use the Cortex-A7 instead of Cortex-A15 Alistair Francis
2017-10-17 23:36 ` Philippe Mathieu-Daudé
2017-10-18 7:48 ` Igor Mammedov [this message]
2017-10-17 22:31 ` [Qemu-devel] [PATCH v3 3/5] raspi: Specify the valid CPUs Alistair Francis
2017-10-17 22:31 ` [Qemu-devel] [PATCH v3 4/5] xlnx-zcu102: " Alistair Francis
2017-10-20 19:16 ` Eduardo Habkost
2017-10-23 11:14 ` Philippe Mathieu-Daudé
2017-10-26 9:59 ` Alistair Francis
2017-11-29 9:09 ` Igor Mammedov
2017-10-17 22:31 ` [Qemu-devel] [PATCH v3 5/5] xilinx_zynq: " Alistair Francis
2017-10-23 7:26 ` [Qemu-devel] [PATCH v3 0/5] Add a valid_cpu_types property Alistair Francis
2017-11-07 23:30 ` Alistair Francis
2017-11-28 23:26 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171018094817.3fef3d8d@nial.brq.redhat.com \
--to=imammedo@redhat.com \
--cc=alistair.francis@xilinx.com \
--cc=alistair23@gmail.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=marcel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).