From: Cornelia Huck <cohuck@redhat.com>
To: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>
Cc: Halil Pasic <pasic@linux.vnet.ibm.com>,
qemu-s390x@nongnu.org, Pierre Morel <pmorel@linux.vnet.ibm.com>,
Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 0/7] improve error handling for IO instr
Date: Wed, 18 Oct 2017 11:53:10 +0200 [thread overview]
Message-ID: <20171018115310.44eec1ed.cohuck@redhat.com> (raw)
In-Reply-To: <20171018082347.GA5150@bjsdjshi@linux.vnet.ibm.com>
On Wed, 18 Oct 2017 16:23:47 +0800
Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com> wrote:
> * Halil Pasic <pasic@linux.vnet.ibm.com> [2017-10-17 18:19:20 +0200]:
>
> [...]
>
> > >> Testing
> > >> =======
> > >>
> > >> Nothing happened since v2 except for a quick smoke test. Dong Jia gave v2
> > >> a spin with a focus on vfio-ccw. @Dong Jia I would appreciate some proper
> > >> testing, especially regarding the changes in vfio-ccw (patch #3).
> > >
> > > Looks sane to me (if needed, I can fix up the minor things I found).
> > >
> > > In addition to some testing, I'd appreciate some review from others as
> > > well.
> > >
> >
> > Of course, I'm fine with the fixes (won't answer individually). I think
> > both Dong Jia and Pierre have already put enough work in this to be credited
> > with a tag, so I really hope they will get around to review this. I would
> > be especially happy with an Tested-by: Dong Jia since this series is quite
> > under-tested, and the changes in vfio-ccw aren't just minor.
> >
> > Of course I could come up with a test setup myself, but I hope Dong Jia
> > already has one, and he is certainly more involved with vfio-ccw.
> >
> Using Conny's s390-next branch + this series (#2-#7), I didn't notice
> any obvious problem during my fio test. So for the vfio-ccw related
> part:
> Tested-by: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>
Thanks!
To which patches may I add the tag? :)
next prev parent reply other threads:[~2017-10-18 9:53 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 14:04 [Qemu-devel] [PATCH v3 0/7] improve error handling for IO instr Halil Pasic
2017-10-17 14:04 ` [Qemu-devel] [PATCH v3 1/7] s390x/css: be more consistent if broken beyond repair Halil Pasic
2017-10-18 8:13 ` Thomas Huth
2017-10-17 14:04 ` [Qemu-devel] [PATCH v3 2/7] s390x/css: IO instr handler ending control Halil Pasic
2017-10-17 14:58 ` Cornelia Huck
2017-10-17 16:13 ` Halil Pasic
2017-10-18 8:45 ` Thomas Huth
2017-10-18 9:34 ` Cornelia Huck
2017-10-18 9:13 ` Dong Jia Shi
2017-10-17 14:04 ` [Qemu-devel] [PATCH v3 3/7] s390x: improve error handling for SSCH and RSCH Halil Pasic
2017-10-17 15:06 ` Cornelia Huck
2017-10-18 9:30 ` Thomas Huth
2017-10-18 9:52 ` Thomas Huth
2017-10-18 9:58 ` Cornelia Huck
2017-10-18 10:02 ` Thomas Huth
2017-10-18 9:52 ` Cornelia Huck
2017-10-18 10:07 ` Thomas Huth
2017-10-18 11:07 ` Halil Pasic
2017-10-18 11:12 ` Thomas Huth
2017-10-18 11:17 ` Halil Pasic
2017-10-19 6:06 ` Dong Jia Shi
2017-10-17 14:04 ` [Qemu-devel] [PATCH v3 4/7] s390x: refactor error handling for XSCH handler Halil Pasic
2017-10-17 15:07 ` Cornelia Huck
2017-10-18 9:33 ` Thomas Huth
2017-10-19 6:11 ` Dong Jia Shi
2017-10-19 9:10 ` Halil Pasic
2017-10-17 14:04 ` [Qemu-devel] [PATCH v3 5/7] s390x: refactor error handling for CSCH handler Halil Pasic
2017-10-17 15:09 ` Cornelia Huck
2017-10-18 9:36 ` Thomas Huth
2017-10-19 6:14 ` Dong Jia Shi
2017-10-19 9:11 ` Cornelia Huck
2017-10-17 14:04 ` [Qemu-devel] [PATCH v3 6/7] s390x: refactor error handling for HSCH handler Halil Pasic
2017-10-17 15:10 ` Cornelia Huck
2017-10-18 9:55 ` Thomas Huth
2017-10-19 6:17 ` Dong Jia Shi
2017-10-17 14:04 ` [Qemu-devel] [PATCH v3 7/7] s390x: refactor error handling for MSCH handler Halil Pasic
2017-10-17 15:11 ` Cornelia Huck
2017-10-18 10:00 ` Thomas Huth
2017-10-18 10:02 ` Cornelia Huck
2017-10-18 11:01 ` Halil Pasic
2017-10-19 6:23 ` Dong Jia Shi
2017-10-17 15:13 ` [Qemu-devel] [PATCH v3 0/7] improve error handling for IO instr Cornelia Huck
2017-10-17 16:19 ` Halil Pasic
2017-10-18 7:38 ` Cornelia Huck
2017-10-18 8:23 ` Dong Jia Shi
2017-10-18 9:53 ` Cornelia Huck [this message]
2017-10-19 6:01 ` Dong Jia Shi
2017-10-18 12:50 ` Cornelia Huck
2017-10-19 10:46 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171018115310.44eec1ed.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=bjsdjshi@linux.vnet.ibm.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=pmorel@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).