From: "Daniel P. Berrange" <berrange@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: Juan Quintela <quintela@redhat.com>,
qemu-devel@nongnu.org, lvivier@redhat.com, peterx@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test
Date: Wed, 18 Oct 2017 14:08:11 +0100 [thread overview]
Message-ID: <20171018130811.GG9719@redhat.com> (raw)
In-Reply-To: <20171018124940.GC2339@work-vm>
On Wed, Oct 18, 2017 at 01:49:42PM +0100, Dr. David Alan Gilbert wrote:
> * Daniel P. Berrange (berrange@redhat.com) wrote:
> > On Wed, Oct 04, 2017 at 12:39:28PM +0200, Juan Quintela wrote:
> > > Signed-off-by: Juan Quintela <quintela@redhat.com>
> > > ---
> > > tests/Makefile.include | 3 +
> > > tests/migration-test.c | 497 +++++++++++++++++++++++++++++++++++++++++++++++++
> > > 2 files changed, 500 insertions(+)
> > > create mode 100644 tests/migration-test.c
> > >
> >
> >
> > > +
> > > +/* A simple PC boot sector that modifies memory (1-100MB) quickly
> > > + * outputing a 'B' every so often if it's still running.
> > > + */
> >
> >
> > Can you add a comment about what it is actually doing to dirty the memory.
>
> Yes, so this is the code from the postcopy tests, the commit message
> ea0c6d62 has the actual source for it.
Ah ha, thanks.
> > eg is it writing a different random value at each byte of RAM, or picking
> > a random value at the stasrt of each iteration and writing it to all RAM,
> > or it is just xoring current memory contents, or something else ?
> >
> > Understanding this would be helpful in understanding how well the tests
> > for xbzrle / compression are working, because the pattern of dirtying
> > memory will affect whether the compression does anything useful or not.
>
> It rolls through 100MB of RAM, incrementing the 1st byte of each page in
> sequence and then goes back and does it again. So it should be
> excellent for xbzrle.
Yes
>
> Dave
>
> > > +unsigned char bootsect[] = {
> > > + 0xfa, 0x0f, 0x01, 0x16, 0x74, 0x7c, 0x66, 0xb8, 0x01, 0x00, 0x00, 0x00,
> > > + 0x0f, 0x22, 0xc0, 0x66, 0xea, 0x20, 0x7c, 0x00, 0x00, 0x08, 0x00, 0x00,
> > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xe4, 0x92, 0x0c, 0x02,
> > > + 0xe6, 0x92, 0xb8, 0x10, 0x00, 0x00, 0x00, 0x8e, 0xd8, 0x66, 0xb8, 0x41,
> > > + 0x00, 0x66, 0xba, 0xf8, 0x03, 0xee, 0xb3, 0x00, 0xb8, 0x00, 0x00, 0x10,
> > > + 0x00, 0xfe, 0x00, 0x05, 0x00, 0x10, 0x00, 0x00, 0x3d, 0x00, 0x00, 0x40,
> > > + 0x06, 0x7c, 0xf2, 0xfe, 0xc3, 0x75, 0xe9, 0x66, 0xb8, 0x42, 0x00, 0x66,
> > > + 0xba, 0xf8, 0x03, 0xee, 0xeb, 0xde, 0x66, 0x90, 0x00, 0x00, 0x00, 0x00,
> > > + 0x00, 0x00, 0x00, 0x00, 0xff, 0xff, 0x00, 0x00, 0x00, 0x9a, 0xcf, 0x00,
> > > + 0xff, 0xff, 0x00, 0x00, 0x00, 0x92, 0xcf, 0x00, 0x27, 0x00, 0x5c, 0x7c,
> > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x55, 0xaa
> > > +};
So lets delete this here. Take the bootsect variable in postcopy-test.c
and put it into a migration-bootsector.c file and link it to both tests.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2017-10-18 13:08 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 10:39 [Qemu-devel] [PATCH 0/6] Add make check tests for Migration Juan Quintela
2017-10-04 10:39 ` [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test Juan Quintela
2017-10-04 12:33 ` Thomas Huth
2017-10-04 12:46 ` Juan Quintela
2017-10-04 13:07 ` Thomas Huth
2017-10-04 15:52 ` Eric Blake
2017-10-09 8:19 ` Peter Xu
2017-10-18 11:49 ` Juan Quintela
2017-10-16 11:59 ` Dr. David Alan Gilbert
2017-10-18 4:26 ` Peter Xu
2017-10-18 11:36 ` Juan Quintela
2017-10-18 12:10 ` Daniel P. Berrange
2017-10-19 3:18 ` Peter Xu
2017-10-19 9:09 ` Daniel P. Berrange
2017-10-19 9:16 ` Dr. David Alan Gilbert
2017-10-19 9:19 ` Daniel P. Berrange
2017-10-19 9:23 ` Dr. David Alan Gilbert
2017-10-19 9:09 ` Dr. David Alan Gilbert
2017-10-18 12:03 ` Daniel P. Berrange
2017-10-18 12:49 ` Dr. David Alan Gilbert
2017-10-18 13:08 ` Daniel P. Berrange [this message]
2017-10-04 10:39 ` [Qemu-devel] [PATCH 2/6] tests: Add basic migration precopy tcp test Juan Quintela
2017-10-16 12:09 ` Dr. David Alan Gilbert
2017-10-18 11:51 ` Juan Quintela
2017-10-04 10:39 ` [Qemu-devel] [PATCH 3/6] tests: Add precopy test using deprecated commands Juan Quintela
2017-10-16 15:40 ` Dr. David Alan Gilbert
2017-10-18 11:52 ` Juan Quintela
2017-10-04 10:39 ` [Qemu-devel] [PATCH 4/6] tests: Add migration xbzrle test Juan Quintela
2017-10-16 16:07 ` Dr. David Alan Gilbert
2017-10-18 11:56 ` Juan Quintela
2017-10-19 9:06 ` Dr. David Alan Gilbert
2017-10-04 10:39 ` [Qemu-devel] [PATCH 5/6] tests: Add migration compress threads tests Juan Quintela
2017-10-09 8:28 ` Peter Xu
2017-10-18 11:59 ` Juan Quintela
2017-10-16 16:29 ` Dr. David Alan Gilbert
2017-10-18 11:57 ` Juan Quintela
2017-10-04 10:39 ` [Qemu-devel] [PATCH 6/6] tests: Move postcopy migration test to migrate-set-parameters Juan Quintela
2017-10-16 16:31 ` Dr. David Alan Gilbert
2017-10-04 13:25 ` [Qemu-devel] [PATCH 0/6] Add make check tests for Migration no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171018130811.GG9719@redhat.com \
--to=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lvivier@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).