From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45178) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4pkM-0002OW-Ka for qemu-devel@nongnu.org; Wed, 18 Oct 2017 10:55:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e4pkJ-0004Ww-By for qemu-devel@nongnu.org; Wed, 18 Oct 2017 10:55:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48830) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e4pkI-0004VI-RK for qemu-devel@nongnu.org; Wed, 18 Oct 2017 10:54:59 -0400 Date: Wed, 18 Oct 2017 16:54:54 +0200 From: Igor Mammedov Message-ID: <20171018165454.3ce3a99f@nial.brq.redhat.com> In-Reply-To: <3039cb1b-cef6-781b-964c-143ab225a88f@redhat.com> References: <1508170976-96869-1-git-send-email-imammedo@redhat.com> <20171016163636.GI11975@redhat.com> <20171017092702.5b82103b@nial.brq.redhat.com> <20171017150759.GB31897@redhat.com> <32e47d96-0292-4511-adb2-24a4766b3027@redhat.com> <20171018122715.GF9719@redhat.com> <20171018162625.094cd3e1@nial.brq.redhat.com> <3039cb1b-cef6-781b-964c-143ab225a88f@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC 0/6] enable numa configuration before machine_init() from HMP/QMP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: "Daniel P. Berrange" , peter.maydell@linaro.org, pkrempa@redhat.com, ehabkost@redhat.com, cohuck@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, david@gibson.dropbear.id.au On Wed, 18 Oct 2017 16:29:38 +0200 Paolo Bonzini wrote: > On 18/10/2017 16:26, Igor Mammedov wrote: > >> I guess query-hotpluggable-cpus could also grow a first-cpu-index in the > >> returned data. > > > > I guess query-cpus can/does provide cpu-index already, > > for query-hotpluggable-cpus it would depend in what's shown there > > (would work fro x86/arm/s390 as they publish there CPUState based objects, > > but spapr puts cores there which themselves do not have cpu-index, > > their children do though) > > Yeah, that's why I put "first-cpu-index". The idea is that indices go > from first-cpu-index to first-cpu-index + vcpus-count - 1. yep, so far it's so. we can also add optional extra entries there for each thread like this: Hotpluggable CPUs: type: "power8_v2.0-spapr-cpu-core" vcpus_count: "1" qom_path: "/machine/unattached/device[0]" children threads: /machine/unattached/device[0]/thread[0] /machine/unattached/device[0]/thread[1] CPUInstance Properties: core-id: "0" or ignore high level query-hotpluggable-cpus and use existing query-cpus which already provides qom path to threads and replace of cpu-index based monitor commands with qom path based ones. (though it won't change fact that both are owned by QEMU) > Paolo