* [Qemu-devel] [PATCH qemu v2 REPOST] pci: Initialize pci_dev->name before use
@ 2017-10-15 4:24 Alexey Kardashevskiy
2017-10-15 8:01 ` Peter Xu
0 siblings, 1 reply; 4+ messages in thread
From: Alexey Kardashevskiy @ 2017-10-15 4:24 UTC (permalink / raw)
To: qemu-devel; +Cc: Alexey Kardashevskiy, Michael S. Tsirkin
This moves pci_dev->name initialization earlier so
pci_dev->bus_master_as could get a name instead of an empty string.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
Changes:
v2:
* fixed mistype in the commit log
* added "rb"
---
hw/pci/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 1e6fb88eba..05c5f75ef0 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -1020,6 +1020,7 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus,
pci_dev->devfn = devfn;
pci_dev->requester_id_cache = pci_req_id_cache_get(pci_dev);
+ pstrcpy(pci_dev->name, sizeof(pci_dev->name), name);
memory_region_init(&pci_dev->bus_master_container_region, OBJECT(pci_dev),
"bus master container", UINT64_MAX);
@@ -1029,7 +1030,6 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus,
if (qdev_hotplug) {
pci_init_bus_master(pci_dev);
}
- pstrcpy(pci_dev->name, sizeof(pci_dev->name), name);
pci_dev->irq_state = 0;
pci_config_alloc(pci_dev);
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH qemu v2 REPOST] pci: Initialize pci_dev->name before use
2017-10-15 4:24 [Qemu-devel] [PATCH qemu v2 REPOST] pci: Initialize pci_dev->name before use Alexey Kardashevskiy
@ 2017-10-15 8:01 ` Peter Xu
2017-10-17 5:00 ` Alexey Kardashevskiy
0 siblings, 1 reply; 4+ messages in thread
From: Peter Xu @ 2017-10-15 8:01 UTC (permalink / raw)
To: Alexey Kardashevskiy; +Cc: qemu-devel, Michael S. Tsirkin
On Sun, Oct 15, 2017 at 03:24:52PM +1100, Alexey Kardashevskiy wrote:
> This moves pci_dev->name initialization earlier so
> pci_dev->bus_master_as could get a name instead of an empty string.
Or use "name" instead of "pci_dev->name" when do address_space_init()?
But I think this one works too.
>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Maybe "Philippe Mathieu-Daudé"?
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Reviewed-by: Peter Xu <peterx@redhat.com>
> ---
>
> Changes:
> v2:
> * fixed mistype in the commit log
> * added "rb"
> ---
> hw/pci/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/pci/pci.c b/hw/pci/pci.c
> index 1e6fb88eba..05c5f75ef0 100644
> --- a/hw/pci/pci.c
> +++ b/hw/pci/pci.c
> @@ -1020,6 +1020,7 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus,
>
> pci_dev->devfn = devfn;
> pci_dev->requester_id_cache = pci_req_id_cache_get(pci_dev);
> + pstrcpy(pci_dev->name, sizeof(pci_dev->name), name);
>
> memory_region_init(&pci_dev->bus_master_container_region, OBJECT(pci_dev),
> "bus master container", UINT64_MAX);
> @@ -1029,7 +1030,6 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus,
> if (qdev_hotplug) {
> pci_init_bus_master(pci_dev);
> }
> - pstrcpy(pci_dev->name, sizeof(pci_dev->name), name);
> pci_dev->irq_state = 0;
> pci_config_alloc(pci_dev);
>
> --
> 2.11.0
>
>
--
Peter Xu
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH qemu v2 REPOST] pci: Initialize pci_dev->name before use
2017-10-15 8:01 ` Peter Xu
@ 2017-10-17 5:00 ` Alexey Kardashevskiy
2017-10-18 17:41 ` Michael S. Tsirkin
0 siblings, 1 reply; 4+ messages in thread
From: Alexey Kardashevskiy @ 2017-10-17 5:00 UTC (permalink / raw)
To: Peter Xu; +Cc: qemu-devel, Michael S. Tsirkin
On 15/10/17 19:01, Peter Xu wrote:
> On Sun, Oct 15, 2017 at 03:24:52PM +1100, Alexey Kardashevskiy wrote:
>> This moves pci_dev->name initialization earlier so
>> pci_dev->bus_master_as could get a name instead of an empty string.
>
> Or use "name" instead of "pci_dev->name" when do address_space_init()?
> But I think this one works too.
>
>>
>> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> Maybe "Philippe Mathieu-Daudé"?
Definitely. Repost?
>
>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>
> Reviewed-by: Peter Xu <peterx@redhat.com>
>
>> ---
>>
>> Changes:
>> v2:
>> * fixed mistype in the commit log
>> * added "rb"
>> ---
>> hw/pci/pci.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/pci/pci.c b/hw/pci/pci.c
>> index 1e6fb88eba..05c5f75ef0 100644
>> --- a/hw/pci/pci.c
>> +++ b/hw/pci/pci.c
>> @@ -1020,6 +1020,7 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus,
>>
>> pci_dev->devfn = devfn;
>> pci_dev->requester_id_cache = pci_req_id_cache_get(pci_dev);
>> + pstrcpy(pci_dev->name, sizeof(pci_dev->name), name);
>>
>> memory_region_init(&pci_dev->bus_master_container_region, OBJECT(pci_dev),
>> "bus master container", UINT64_MAX);
>> @@ -1029,7 +1030,6 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus,
>> if (qdev_hotplug) {
>> pci_init_bus_master(pci_dev);
>> }
>> - pstrcpy(pci_dev->name, sizeof(pci_dev->name), name);
>> pci_dev->irq_state = 0;
>> pci_config_alloc(pci_dev);
>>
>> --
>> 2.11.0
>>
>>
>
--
Alexey
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH qemu v2 REPOST] pci: Initialize pci_dev->name before use
2017-10-17 5:00 ` Alexey Kardashevskiy
@ 2017-10-18 17:41 ` Michael S. Tsirkin
0 siblings, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2017-10-18 17:41 UTC (permalink / raw)
To: Alexey Kardashevskiy; +Cc: Peter Xu, qemu-devel
On Tue, Oct 17, 2017 at 04:00:05PM +1100, Alexey Kardashevskiy wrote:
> On 15/10/17 19:01, Peter Xu wrote:
> > On Sun, Oct 15, 2017 at 03:24:52PM +1100, Alexey Kardashevskiy wrote:
> >> This moves pci_dev->name initialization earlier so
> >> pci_dev->bus_master_as could get a name instead of an empty string.
> >
> > Or use "name" instead of "pci_dev->name" when do address_space_init()?
> > But I think this one works too.
> >
> >>
> >> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> >
> > Maybe "Philippe Mathieu-Daudé"?
>
>
> Definitely. Repost?
Yes pls.
>
> >
> >> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> >
> > Reviewed-by: Peter Xu <peterx@redhat.com>
> >
> >> ---
> >>
> >> Changes:
> >> v2:
> >> * fixed mistype in the commit log
> >> * added "rb"
> >> ---
> >> hw/pci/pci.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/hw/pci/pci.c b/hw/pci/pci.c
> >> index 1e6fb88eba..05c5f75ef0 100644
> >> --- a/hw/pci/pci.c
> >> +++ b/hw/pci/pci.c
> >> @@ -1020,6 +1020,7 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus,
> >>
> >> pci_dev->devfn = devfn;
> >> pci_dev->requester_id_cache = pci_req_id_cache_get(pci_dev);
> >> + pstrcpy(pci_dev->name, sizeof(pci_dev->name), name);
> >>
> >> memory_region_init(&pci_dev->bus_master_container_region, OBJECT(pci_dev),
> >> "bus master container", UINT64_MAX);
> >> @@ -1029,7 +1030,6 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus,
> >> if (qdev_hotplug) {
> >> pci_init_bus_master(pci_dev);
> >> }
> >> - pstrcpy(pci_dev->name, sizeof(pci_dev->name), name);
> >> pci_dev->irq_state = 0;
> >> pci_config_alloc(pci_dev);
> >>
> >> --
> >> 2.11.0
> >>
> >>
> >
>
>
> --
> Alexey
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-18 17:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-15 4:24 [Qemu-devel] [PATCH qemu v2 REPOST] pci: Initialize pci_dev->name before use Alexey Kardashevskiy
2017-10-15 8:01 ` Peter Xu
2017-10-17 5:00 ` Alexey Kardashevskiy
2017-10-18 17:41 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).