From: "Cédric Le Goater" <clg@kaod.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org,
"Andrew Jeffery" <andrew@aj.id.au>,
"Joel Stanley" <joel@jms.id.au>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Cédric Le Goater" <clg@kaod.org>
Subject: [Qemu-devel] [PATCH v4 2/8] aspeed: remove ignore_memory_transaction_failures on all boards
Date: Thu, 19 Oct 2017 12:04:04 +0200 [thread overview]
Message-ID: <20171019100410.26239-3-clg@kaod.org> (raw)
In-Reply-To: <20171019100410.26239-1-clg@kaod.org>
Now that we have a dummy ROM device catching the invalid writes, we
can remove this flag and work on fixing the current firwmares still
accessing unimplemented addresses.
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
hw/arm/aspeed.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
index e44733153819..dbb02f568462 100644
--- a/hw/arm/aspeed.c
+++ b/hw/arm/aspeed.c
@@ -294,7 +294,6 @@ static void palmetto_bmc_class_init(ObjectClass *oc, void *data)
mc->no_floppy = 1;
mc->no_cdrom = 1;
mc->no_parallel = 1;
- mc->ignore_memory_transaction_failures = true;
}
static const TypeInfo palmetto_bmc_type = {
@@ -327,7 +326,6 @@ static void ast2500_evb_class_init(ObjectClass *oc, void *data)
mc->no_floppy = 1;
mc->no_cdrom = 1;
mc->no_parallel = 1;
- mc->ignore_memory_transaction_failures = true;
}
static const TypeInfo ast2500_evb_type = {
@@ -352,7 +350,6 @@ static void romulus_bmc_class_init(ObjectClass *oc, void *data)
mc->no_floppy = 1;
mc->no_cdrom = 1;
mc->no_parallel = 1;
- mc->ignore_memory_transaction_failures = true;
}
static const TypeInfo romulus_bmc_type = {
--
2.13.6
next prev parent reply other threads:[~2017-10-19 10:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 10:04 [Qemu-devel] [PATCH v4 0/8] aspeed: add a witherspoon-bmc machine Cédric Le Goater
2017-10-19 10:04 ` [Qemu-devel] [PATCH v4 1/8] aspeed: introduce a dummy ROM device to catch invalid writes Cédric Le Goater
2017-10-19 11:06 ` Peter Maydell
2017-10-19 12:57 ` Cédric Le Goater
2017-10-19 10:04 ` Cédric Le Goater [this message]
2017-10-19 10:04 ` [Qemu-devel] [PATCH v4 3/8] aspeed: add support for the witherspoon-bmc board Cédric Le Goater
2017-10-19 10:04 ` [Qemu-devel] [PATCH v4 4/8] aspeed: add an I2C RTC device to all machines Cédric Le Goater
2017-10-19 10:04 ` [Qemu-devel] [PATCH v4 5/8] smbus: add a smbus_eeprom_init_one() routine Cédric Le Goater
2017-10-19 10:04 ` [Qemu-devel] [PATCH v4 6/8] aspeed: Add EEPROM I2C devices Cédric Le Goater
2017-10-19 10:04 ` [Qemu-devel] [PATCH v4 7/8] misc: add pca9552 LED blinker model Cédric Le Goater
2017-10-19 10:04 ` [Qemu-devel] [PATCH v4 8/8] aspeed: add the pc9552 chips to the witherspoon machine Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019100410.26239-3-clg@kaod.org \
--to=clg@kaod.org \
--cc=andrew@aj.id.au \
--cc=f4bug@amsat.org \
--cc=joel@jms.id.au \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).