qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] docker: fix out-of-tree 'make docker-test-build@debian-powerpc-cross'
@ 2017-10-19 11:40 Greg Kurz
  2017-10-19 12:24 ` [Qemu-devel] [Qemu-trivial] " Philippe Mathieu-Daudé
  2017-10-19 14:10 ` [Qemu-devel] " Fam Zheng
  0 siblings, 2 replies; 3+ messages in thread
From: Greg Kurz @ 2017-10-19 11:40 UTC (permalink / raw)
  To: qemu-devel
  Cc: qemu-trivial, Alex Bennée, Fam Zheng,
	Philippe Mathieu-Daudé

Without this patch, it fails with:

IOError: [Errno 2] No such file or directory:
 'tests/docker/dockerfiles/debian-apt-fake.sh'

Signed-off-by: Greg Kurz <groug@kaod.org>
---
 tests/docker/Makefile.include |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
index 6f9ea196a7b8..5d54eca5d0b3 100644
--- a/tests/docker/Makefile.include
+++ b/tests/docker/Makefile.include
@@ -44,7 +44,7 @@ docker-image-%: $(DOCKER_FILES_DIR)/%.docker
 		$(if $(EXECUTABLE),--include-executable=$(EXECUTABLE)),\
 		"BUILD","$*")
 
-docker-image-debian-powerpc-cross: EXTRA_FILES:=tests/docker/dockerfiles/debian-apt-fake.sh
+docker-image-debian-powerpc-cross: EXTRA_FILES:=$(SRC_PATH)/tests/docker/dockerfiles/debian-apt-fake.sh
 
 # Enforce dependancies for composite images
 docker-image-debian: docker-image-debian9

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [Qemu-trivial] [PATCH] docker: fix out-of-tree 'make docker-test-build@debian-powerpc-cross'
  2017-10-19 11:40 [Qemu-devel] [PATCH] docker: fix out-of-tree 'make docker-test-build@debian-powerpc-cross' Greg Kurz
@ 2017-10-19 12:24 ` Philippe Mathieu-Daudé
  2017-10-19 14:10 ` [Qemu-devel] " Fam Zheng
  1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2017-10-19 12:24 UTC (permalink / raw)
  To: Greg Kurz, qemu-devel; +Cc: qemu-trivial, Fam Zheng, Alex Bennée

On 10/19/2017 08:40 AM, Greg Kurz wrote:
> Without this patch, it fails with:
> 
> IOError: [Errno 2] No such file or directory:
>  'tests/docker/dockerfiles/debian-apt-fake.sh'

Yes, my bad :)

I have the same fix in my CI-WIP branch which sadly lacks of love.

> 
> Signed-off-by: Greg Kurz <groug@kaod.org>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>  tests/docker/Makefile.include |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
> index 6f9ea196a7b8..5d54eca5d0b3 100644
> --- a/tests/docker/Makefile.include
> +++ b/tests/docker/Makefile.include
> @@ -44,7 +44,7 @@ docker-image-%: $(DOCKER_FILES_DIR)/%.docker
>  		$(if $(EXECUTABLE),--include-executable=$(EXECUTABLE)),\
>  		"BUILD","$*")
>  
> -docker-image-debian-powerpc-cross: EXTRA_FILES:=tests/docker/dockerfiles/debian-apt-fake.sh
> +docker-image-debian-powerpc-cross: EXTRA_FILES:=$(SRC_PATH)/tests/docker/dockerfiles/debian-apt-fake.sh
>  
>  # Enforce dependancies for composite images
>  docker-image-debian: docker-image-debian9

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [PATCH] docker: fix out-of-tree 'make docker-test-build@debian-powerpc-cross'
  2017-10-19 11:40 [Qemu-devel] [PATCH] docker: fix out-of-tree 'make docker-test-build@debian-powerpc-cross' Greg Kurz
  2017-10-19 12:24 ` [Qemu-devel] [Qemu-trivial] " Philippe Mathieu-Daudé
@ 2017-10-19 14:10 ` Fam Zheng
  1 sibling, 0 replies; 3+ messages in thread
From: Fam Zheng @ 2017-10-19 14:10 UTC (permalink / raw)
  To: Greg Kurz
  Cc: qemu-devel, qemu-trivial, Alex Bennée,
	Philippe Mathieu-Daudé

On Thu, 10/19 13:40, Greg Kurz wrote:
> Without this patch, it fails with:
> 
> IOError: [Errno 2] No such file or directory:
>  'tests/docker/dockerfiles/debian-apt-fake.sh'
> 
> Signed-off-by: Greg Kurz <groug@kaod.org>

Reasonable. Queued, thanks!

Fam

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-10-19 14:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-19 11:40 [Qemu-devel] [PATCH] docker: fix out-of-tree 'make docker-test-build@debian-powerpc-cross' Greg Kurz
2017-10-19 12:24 ` [Qemu-devel] [Qemu-trivial] " Philippe Mathieu-Daudé
2017-10-19 14:10 ` [Qemu-devel] " Fam Zheng

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).