From: Cornelia Huck <cohuck@redhat.com>
To: Halil Pasic <pasic@linux.vnet.ibm.com>
Cc: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>,
Pierre Morel <pmorel@linux.vnet.ibm.com>,
qemu-devel@nongnu.org,
Christian Borntraeger <borntraeger@de.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated device
Date: Fri, 20 Oct 2017 15:00:43 +0200 [thread overview]
Message-ID: <20171020150043.383b2117.cohuck@redhat.com> (raw)
In-Reply-To: <711b1e41-693a-de7d-9c13-fbe0f964c53c@linux.vnet.ibm.com>
On Thu, 19 Oct 2017 18:39:37 +0200
Halil Pasic <pasic@linux.vnet.ibm.com> wrote:
> On 09/15/2017 09:27 AM, Cornelia Huck wrote:
> >>>
> >>>> + DEFINE_PROP_UINT8("chpid_type", CcwTesterDevice, chpid_type,
> >>>> + 0x98),
> > This might also need re-evaluation - we should not really need a new
> > chpid type.
> >
>
> I'm back at ccw-tester again (for v2). I've realized we did not agree
> on what to use here (chpid_type). Shall I use 0x25 (Fibre Channel) or
> EMULATED_CCW_3270_CHPID_TYPE, or even 0x32 (virtio-ccw) as a default
> value? And should EMULATED_CCW_3270_CHPID_TYPE be called like that
> (is it really supposed to be specific to 3270?
>
> Sorry I did not notice sooner.
It might make sense to pick whatever z/VM commonly uses for emulated
devices. (Or ask them if they reserved something explicitly for testing
-- that would be an even better match.)
next prev parent reply other threads:[~2017-10-20 13:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-13 13:27 [Qemu-devel] [PATCH 0/2] tests for CCW IDA Halil Pasic
2017-09-13 13:27 ` [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated device Halil Pasic
2017-09-14 14:26 ` Cornelia Huck
2017-09-14 16:50 ` Halil Pasic
2017-09-15 7:27 ` Cornelia Huck
2017-09-15 17:01 ` Cornelia Huck
2017-09-19 14:20 ` Pierre Morel
2017-09-25 15:06 ` Halil Pasic
2017-09-25 15:39 ` Cornelia Huck
2017-09-18 8:30 ` Christian Borntraeger
2017-09-18 8:42 ` Cornelia Huck
2017-10-19 16:39 ` Halil Pasic
2017-10-20 13:00 ` Cornelia Huck [this message]
2017-10-20 14:33 ` Halil Pasic
2017-10-20 15:46 ` Cornelia Huck
2017-09-19 14:26 ` Pierre Morel
2017-09-13 13:27 ` [Qemu-devel] [PATCH 2/2 NOT QEMU] a tester device for ccw I/O Halil Pasic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171020150043.383b2117.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=bjsdjshi@linux.vnet.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=pmorel@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).