From: Kevin Wolf <kwolf@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, jsnow@redhat.com, famz@redhat.com,
qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v6 23/24] qcow2: Relax is_zero() assertion
Date: Fri, 20 Oct 2017 17:11:18 +0200 [thread overview]
Message-ID: <20171020151118.GD3667@localhost.localdomain> (raw)
In-Reply-To: <61e393f8-fcc5-b098-d6f2-160091c448c2@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 533 bytes --]
Am 12.10.2017 um 15:20 hat Eric Blake geschrieben:
> On 10/11/2017 10:47 PM, Eric Blake wrote:
> > Now that bdrv_is_allocated accepts non-aligned inputs, we can
> > remove the TODO added in earlier refactoring.
> >
> > Signed-off-by: Eric Blake <eblake@redhat.com>
>
> I was a bit too hasty in the copy-and-paste from 22/24 - there is no
> assertion in this patch, so the subject would be better as:
>
> qcow2: Reduce is_zero() rounding
In fact, I don't see any assertion being modified in patch 22 either.
Kevin
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2017-10-20 15:12 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 3:46 [Qemu-devel] [PATCH v6 00/24] make bdrv_get_block_status byte-based Eric Blake
2017-10-12 3:46 ` [Qemu-devel] [PATCH v6 01/24] block: Allow NULL file for bdrv_get_block_status() Eric Blake
2017-10-12 3:46 ` [Qemu-devel] [PATCH v6 02/24] block: Add flag to avoid wasted work in bdrv_is_allocated() Eric Blake
2017-10-12 3:46 ` [Qemu-devel] [PATCH v6 03/24] block: Make bdrv_round_to_clusters() signature more useful Eric Blake
2017-10-12 3:47 ` [Qemu-devel] [PATCH v6 04/24] qcow2: Switch is_zero_sectors() to byte-based Eric Blake
2017-10-12 3:47 ` [Qemu-devel] [PATCH v6 05/24] block: Switch bdrv_make_zero() " Eric Blake
2017-10-12 3:47 ` [Qemu-devel] [PATCH v6 06/24] qemu-img: Switch get_block_status() " Eric Blake
2017-10-12 3:47 ` [Qemu-devel] [PATCH v6 07/24] block: Convert bdrv_get_block_status() to bytes Eric Blake
2017-10-20 14:31 ` Kevin Wolf
2017-10-20 15:12 ` Eric Blake
2017-10-20 15:31 ` Kevin Wolf
2017-10-12 3:47 ` [Qemu-devel] [PATCH v6 08/24] block: Switch bdrv_co_get_block_status() to byte-based Eric Blake
2017-10-12 3:47 ` [Qemu-devel] [PATCH v6 09/24] block: Switch BdrvCoGetBlockStatusData " Eric Blake
2017-10-12 3:47 ` [Qemu-devel] [PATCH v6 10/24] block: Switch bdrv_common_block_status_above() " Eric Blake
2017-10-12 3:47 ` [Qemu-devel] [PATCH v6 11/24] block: Switch bdrv_co_get_block_status_above() " Eric Blake
2017-10-12 3:47 ` [Qemu-devel] [PATCH v6 12/24] block: Convert bdrv_get_block_status_above() to bytes Eric Blake
2017-10-20 15:03 ` Kevin Wolf
2017-10-20 15:22 ` Eric Blake
2017-10-20 15:34 ` Kevin Wolf
2017-10-12 3:47 ` [Qemu-devel] [PATCH v6 13/24] qemu-img: Simplify logic in img_compare() Eric Blake
2017-10-12 3:47 ` [Qemu-devel] [PATCH v6 14/24] qemu-img: Speed up compare on pre-allocated larger file Eric Blake
2017-10-12 3:47 ` [Qemu-devel] [PATCH v6 15/24] qemu-img: Add find_nonzero() Eric Blake
2017-10-12 3:47 ` [Qemu-devel] [PATCH v6 16/24] qemu-img: Drop redundant error message in compare Eric Blake
2017-10-12 3:47 ` [Qemu-devel] [PATCH v6 17/24] qemu-img: Change check_empty_sectors() to byte-based Eric Blake
2017-10-12 3:47 ` [Qemu-devel] [PATCH v6 18/24] qemu-img: Change compare_sectors() to be byte-based Eric Blake
2017-10-12 3:47 ` [Qemu-devel] [PATCH v6 19/24] qemu-img: Change img_rebase() " Eric Blake
2017-10-12 3:47 ` [Qemu-devel] [PATCH v6 20/24] qemu-img: Change img_compare() " Eric Blake
2017-10-12 3:47 ` [Qemu-devel] [PATCH v6 21/24] block: Align block status requests Eric Blake
2017-10-12 3:47 ` [Qemu-devel] [PATCH v6 22/24] block: Relax bdrv_aligned_preadv() assertion Eric Blake
2017-10-12 3:47 ` [Qemu-devel] [PATCH v6 23/24] qcow2: Relax is_zero() assertion Eric Blake
2017-10-12 13:20 ` Eric Blake
2017-10-20 15:11 ` Kevin Wolf [this message]
2017-10-20 15:32 ` Eric Blake
2017-10-12 3:47 ` [Qemu-devel] [PATCH v6 24/24] qemu-io: Relax 'alloc' now that block-status doesn't assert Eric Blake
2017-10-20 16:45 ` [Qemu-devel] [PATCH v6 00/24] make bdrv_get_block_status byte-based Kevin Wolf
2017-11-02 21:01 ` John Snow
2017-11-02 22:14 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171020151118.GD3667@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=jsnow@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).