From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35384) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e5fQa-0001zt-4B for qemu-devel@nongnu.org; Fri, 20 Oct 2017 18:06:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e5fQW-0003ox-18 for qemu-devel@nongnu.org; Fri, 20 Oct 2017 18:06:04 -0400 Received: from mail-pf0-x244.google.com ([2607:f8b0:400e:c00::244]:52475) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e5fQV-0003on-S3 for qemu-devel@nongnu.org; Fri, 20 Oct 2017 18:05:59 -0400 Received: by mail-pf0-x244.google.com with SMTP id e64so12864924pfk.9 for ; Fri, 20 Oct 2017 15:05:59 -0700 (PDT) From: Stafford Horne Date: Sat, 21 Oct 2017 07:05:33 +0900 Message-Id: <20171020220533.29186-6-shorne@gmail.com> In-Reply-To: <20171020220533.29186-1-shorne@gmail.com> References: <20171020220533.29186-1-shorne@gmail.com> Subject: [Qemu-devel] [PULL v2 5/5] openrisc: Only kick cpu on timeout, not on update List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , QEMU Development Cc: Stafford Horne Previously we were kicking the cpu on every update. This caused problems noticeable in SMP configurations where one CPU got pinned continuously servicing timer exceptions. Reviewed-by: Richard Henderson Signed-off-by: Stafford Horne --- hw/openrisc/cputimer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/openrisc/cputimer.c b/hw/openrisc/cputimer.c index 4c5415ff75..850f88761c 100644 --- a/hw/openrisc/cputimer.c +++ b/hw/openrisc/cputimer.c @@ -78,7 +78,6 @@ void cpu_openrisc_timer_update(OpenRISCCPU *cpu) } next = now + (uint64_t)wait * TIMER_PERIOD; timer_mod(cpu->env.timer, next); - qemu_cpu_kick(CPU(cpu)); } void cpu_openrisc_count_start(OpenRISCCPU *cpu) @@ -120,6 +119,7 @@ static void openrisc_timer_cb(void *opaque) } cpu_openrisc_timer_update(cpu); + qemu_cpu_kick(CPU(cpu)); } static const VMStateDescription vmstate_or1k_timer = { -- 2.13.6