From: David Gibson <david@gibson.dropbear.id.au>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: John Arbuckle <programmingkidx@gmail.com>,
devicetree-compiler@vger.kernel.org, qemu-ppc@nongnu.org,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [libfdt][PATCH v2] implement strnlen for systems that need it
Date: Sun, 22 Oct 2017 16:33:15 +1100 [thread overview]
Message-ID: <20171022053315.GA15297@umbus> (raw)
In-Reply-To: <f9bd98f1-d45c-6d3a-c35c-c67da67c881f@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 778 bytes --]
On Fri, Oct 20, 2017 at 04:44:58PM -0700, Richard Henderson wrote:
> On 10/20/2017 10:55 AM, John Arbuckle wrote:
> > +static inline size_t strnlen(const char *string, size_t max_count)
> > +{
> > + size_t count;
> > + for (count = 0; count < max_count; count++) {
> > + if (string[count] == '\0') {
> > + break;
> > + }
> > + }
> > + return count;
>
> Not to nitpick, but
>
> const char *p = memchr(string, 0, max_count);
> return p ? max_count : p - string;
Richard's right, that's definitely a better implementation.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-10-22 8:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 17:55 [Qemu-devel] [libfdt][PATCH v2] implement strnlen for systems that need it John Arbuckle
2017-10-20 23:44 ` Richard Henderson
2017-10-22 5:33 ` David Gibson [this message]
2017-10-22 14:41 ` Programmingkid
2017-10-22 15:05 ` John Reiser
2017-10-22 19:06 ` Ian Lepore
2017-10-22 19:52 ` Programmingkid
2017-10-24 4:16 ` Programmingkid
2017-10-24 16:31 ` David Gibson
2017-10-22 13:37 ` Peter Maydell
2017-10-22 14:29 ` Programmingkid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171022053315.GA15297@umbus \
--to=david@gibson.dropbear.id.au \
--cc=devicetree-compiler@vger.kernel.org \
--cc=programmingkidx@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).