From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Daniel P. Berrange" <berrange@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PULL 3/3] scripts: don't throw away stderr when checking out git submodules
Date: Mon, 23 Oct 2017 10:02:45 +0200 [thread overview]
Message-ID: <20171023080245.31300-4-kraxel@redhat.com> (raw)
In-Reply-To: <20171023080245.31300-1-kraxel@redhat.com>
From: "Daniel P. Berrange" <berrange@redhat.com>
The stderr from git is important if git fails to checkout modules
due to network problems, or other unexpected errors.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 20171020130748.22983-1-berrange@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
scripts/git-submodule.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/git-submodule.sh b/scripts/git-submodule.sh
index d8fbc7e47e..08932a35f0 100755
--- a/scripts/git-submodule.sh
+++ b/scripts/git-submodule.sh
@@ -32,7 +32,7 @@ status)
exit $?
;;
update)
- git submodule update --init $modules 1>/dev/null 2>&1
+ git submodule update --init $modules 1>/dev/null
git submodule status $modules > "${substat}"
;;
esac
--
2.9.3
next prev parent reply other threads:[~2017-10-23 8:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-23 8:02 [Qemu-devel] [PULL 0/3] Fixes 20171023 patches Gerd Hoffmann
2017-10-23 8:02 ` [Qemu-devel] [PULL 1/3] configure: disable qemu-keymap for linux-user qemu Gerd Hoffmann
2017-10-23 8:02 ` [Qemu-devel] [PULL 2/3] ui: add qemu-keymap and shader to .gitignore Gerd Hoffmann
2017-10-23 8:02 ` Gerd Hoffmann [this message]
2017-10-23 8:10 ` [Qemu-devel] [PULL 0/3] Fixes 20171023 patches no-reply
2017-10-24 15:06 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171023080245.31300-4-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).