qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, ehabkost@redhat.com
Subject: Re: [Qemu-devel] [PATCH v5 4/6] memfd: add hugetlb support
Date: Mon, 23 Oct 2017 12:33:34 +0100	[thread overview]
Message-ID: <20171023113334.GI16472@redhat.com> (raw)
In-Reply-To: <1938855984.30684033.1508758051014.JavaMail.zimbra@redhat.com>

On Mon, Oct 23, 2017 at 07:27:31AM -0400, Marc-André Lureau wrote:
> Hi
> 
> ----- Original Message -----
> > On Mon, Oct 23, 2017 at 10:59:08AM +0100, Marc-André Lureau wrote:
> > > Linux commit 749df87bd7bee5a79cef073f5d032ddb2b211de8 (v4.14-rc1)
> > > added a new flag MFD_HUGETLB to memfd_create() that specify the file
> > > to be created resides in the hugetlbfs filesystem.  This is the
> > > generic hugetlbfs filesystem not associated with any specific mount
> > > point.
> > 
> > How do you know and/or control what size huge pages are used,
> > when the platform supports many sizes ?
> 
> From linux commit message:
> "As with other system calls that request hugetlbfs backed pages, there is
> the ability to encode huge page size in the flag arguments."
> 
> I didn't add this option to memfd backend, as I don't know how generally
> useful that is, and if there is already a similar option in qemu (probably
> not?). It could be easily added later.

For the existing  memory-backend-file, libvirt controls hugepage size
based on what's requested in guest XML. So if we were to support the
new memory-backend-memfd as an alternative, I think we need to be able
to choose huge page size for that too.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

  reply	other threads:[~2017-10-23 11:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-23  9:59 [Qemu-devel] [PATCH v5 0/6] Add memfd memory backend Marc-André Lureau
2017-10-23  9:59 ` [Qemu-devel] [PATCH v5 1/6] memfd: split qemu_memfd_alloc() Marc-André Lureau
2017-10-23 11:02   ` Philippe Mathieu-Daudé
2017-10-23  9:59 ` [Qemu-devel] [PATCH v5 2/6] memfd: remove needless include Marc-André Lureau
2017-10-23 10:59   ` Philippe Mathieu-Daudé
2017-10-23  9:59 ` [Qemu-devel] [PATCH v5 3/6] memfd: add error argument, instead of perror() Marc-André Lureau
2017-10-23  9:59 ` [Qemu-devel] [PATCH v5 4/6] memfd: add hugetlb support Marc-André Lureau
2017-10-23 10:23   ` Daniel P. Berrange
2017-10-23 11:27     ` Marc-André Lureau
2017-10-23 11:33       ` Daniel P. Berrange [this message]
2017-10-23  9:59 ` [Qemu-devel] [PATCH v5 5/6] Add memfd based hostmem Marc-André Lureau
2017-10-23 11:36   ` Daniel P. Berrange
2017-10-23 11:41     ` Marc-André Lureau
2017-10-23 11:47       ` Daniel P. Berrange
2017-10-23  9:59 ` [Qemu-devel] [PATCH v5 6/6] tests: use memfd in vhost-user-test Marc-André Lureau
2017-10-23 10:26   ` Daniel P. Berrange

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171023113334.GI16472@redhat.com \
    --to=berrange@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).