From: Vadim Galitsyn <vadim.galitsyn@profitbricks.com>
To: vadim.galitsyn@profitbricks.com,
Markus Armbruster <armbru@redhat.com>,
Eric Blake <eblake@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
qemu-devel@nongnu.org
Subject: [Qemu-devel] QMP, HMP: introduce 'writeconfig' command
Date: Mon, 23 Oct 2017 17:13:06 +0200 [thread overview]
Message-ID: <20171023151310.6462-1-vadim.galitsyn@profitbricks.com> (raw)
Hi Guys,
This thread is a continuation of discussion started in
http://lists.nongnu.org/archive/html/qemu-devel/2017-02/msg03182.html.
This series introduces ‘writeconfig’ command support for QMP and HMP monitors. This functionality might be useful for live migration for cases when guest configuration was modified in runtime (for example as a result of hot- plug/unplug operations) and actual Qemu command line no longer reflects setup exposed to guest.
Original series has ‘qemu_opts’ patch as well (http://lists.nongnu.org/archive/html/qemu-devel/2017-02/msg03183.html) because HMP’s ‘object_add’ result was not reflected in ‘writeconfig’ output. Later I found that QMP’s ‘object-add’ has the same issue. Anyway, I don’t include ‘qemu_opts’ patches here because Markus mentioned (here http://lists.nongnu.org/archive/html/qemu-devel/2017-02/msg03476.html) that this functionality is going to be reworked in some future and such patches might collide with the rework process.
Markus, could you please post if you have an update on this topic? Current ‘master’ branch (9993c82dc2f5ce58b41d708b765e1a717ad4281d) still has the issue.
Also, Markus mentioned that once configuration was changed during live migration -- it might be an issue because ‘writeconfig’ data became outdated (and might be make sense to think about to embed this data into migration stream itself). In the same time David said that this is another problem which is unrelated to this patch series. What is your current opinion on this topic? Can we consider these patches to be included into ‘master’ taking into account that not all configuration is dumped by ‘writeconfig’ (‘object_add’ problem), but this can be fixed later?
Best regards,
Vadim
next reply other threads:[~2017-10-23 15:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-23 15:13 Vadim Galitsyn [this message]
2017-10-23 15:13 ` [Qemu-devel] [PATCH 1/4] qmp: introduce 'writeconfig' command Vadim Galitsyn
2017-10-25 12:02 ` Eduardo Otubo
2017-10-26 11:37 ` Marc-André Lureau
2017-10-23 15:13 ` [Qemu-devel] [PATCH 2/4] hmp: " Vadim Galitsyn
2017-10-24 10:41 ` Dr. David Alan Gilbert
2017-10-25 12:04 ` Eduardo Otubo
2017-10-23 15:13 ` [Qemu-devel] [PATCH 3/4] tests: test-hmp: extend with " Vadim Galitsyn
2017-10-25 12:04 ` Eduardo Otubo
2017-10-23 15:13 ` [Qemu-devel] [PATCH 4/4] tests: test-hmp: print command execution result Vadim Galitsyn
2017-10-25 12:03 ` Eduardo Otubo
2017-12-14 11:00 ` Dr. David Alan Gilbert
2017-10-24 10:45 ` [Qemu-devel] QMP, HMP: introduce 'writeconfig' command Dr. David Alan Gilbert
2017-11-13 12:36 ` Markus Armbruster
2017-12-14 17:03 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171023151310.6462-1-vadim.galitsyn@profitbricks.com \
--to=vadim.galitsyn@profitbricks.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).