From: Vadim Galitsyn <vadim.galitsyn@profitbricks.com>
To: vadim.galitsyn@profitbricks.com,
Markus Armbruster <armbru@redhat.com>,
Eric Blake <eblake@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
qemu-devel@nongnu.org
Cc: Eduardo Otubo <eduardo.otubo@profitbricks.com>
Subject: [Qemu-devel] [PATCH 1/4] qmp: introduce 'writeconfig' command
Date: Mon, 23 Oct 2017 17:13:07 +0200 [thread overview]
Message-ID: <20171023151310.6462-2-vadim.galitsyn@profitbricks.com> (raw)
In-Reply-To: <20171023151310.6462-1-vadim.galitsyn@profitbricks.com>
Add support for `writeconfig' command for QMP monitor.
This is a simple way to keep track of current state of VM
after series of hotplugs and/or hotunplugs of different devices.
Signed-off-by: Vadim Galitsyn <vadim.galitsyn@profitbricks.com>
Signed-off-by: Eduardo Otubo <eduardo.otubo@profitbricks.com>
Cc: Markus Armbruster <armbru@redhat.com>
Cc: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org
---
qapi-schema.json | 18 ++++++++++++++++++
qmp.c | 21 +++++++++++++++++++++
2 files changed, 39 insertions(+)
diff --git a/qapi-schema.json b/qapi-schema.json
index a9dd043f65..083f8f3258 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -3200,3 +3200,21 @@
# Since: 2.11
##
{ 'command': 'watchdog-set-action', 'data' : {'action': 'WatchdogAction'} }
+
+##
+# @writeconfig:
+#
+# Dump current configuration into specified file
+#
+# @file: pathname of a file to store current configuration
+#
+# Since: 2.11
+#
+# Example:
+#
+# -> { "execute": "writeconfig",
+# "arguments": { "file": "/tmp/qemu.conf" } }
+# <- { "return": {} }
+#
+##
+{ 'command': 'writeconfig', 'data': {'file': 'str'} }
diff --git a/qmp.c b/qmp.c
index e8c303116a..fcb911cabb 100644
--- a/qmp.c
+++ b/qmp.c
@@ -722,3 +722,24 @@ MemoryInfo *qmp_query_memory_size_summary(Error **errp)
return mem_info;
}
+
+void qmp_writeconfig(const char *file, Error **errp)
+{
+ int fd;
+ FILE *fp;
+
+ fd = qemu_open(file, O_WRONLY | O_CREAT | O_TRUNC, 0600);
+ if (fd != -1) {
+
+ fp = fdopen(fd, "wb");
+ if (fp) {
+ qemu_config_write(fp);
+ fclose(fp);
+ return;
+ }
+
+ qemu_close(fd);
+ }
+
+ error_setg(errp, "cannot write configuration file: '%s'", file);
+}
--
2.13.1.394.g41dd433
next prev parent reply other threads:[~2017-10-23 15:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-23 15:13 [Qemu-devel] QMP, HMP: introduce 'writeconfig' command Vadim Galitsyn
2017-10-23 15:13 ` Vadim Galitsyn [this message]
2017-10-25 12:02 ` [Qemu-devel] [PATCH 1/4] qmp: " Eduardo Otubo
2017-10-26 11:37 ` Marc-André Lureau
2017-10-23 15:13 ` [Qemu-devel] [PATCH 2/4] hmp: " Vadim Galitsyn
2017-10-24 10:41 ` Dr. David Alan Gilbert
2017-10-25 12:04 ` Eduardo Otubo
2017-10-23 15:13 ` [Qemu-devel] [PATCH 3/4] tests: test-hmp: extend with " Vadim Galitsyn
2017-10-25 12:04 ` Eduardo Otubo
2017-10-23 15:13 ` [Qemu-devel] [PATCH 4/4] tests: test-hmp: print command execution result Vadim Galitsyn
2017-10-25 12:03 ` Eduardo Otubo
2017-12-14 11:00 ` Dr. David Alan Gilbert
2017-10-24 10:45 ` [Qemu-devel] QMP, HMP: introduce 'writeconfig' command Dr. David Alan Gilbert
2017-11-13 12:36 ` Markus Armbruster
2017-12-14 17:03 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171023151310.6462-2-vadim.galitsyn@profitbricks.com \
--to=vadim.galitsyn@profitbricks.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo.otubo@profitbricks.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).