qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: dgilbert@redhat.com, lvivier@redhat.com, peterx@redhat.com
Subject: [Qemu-devel] [PULL 11/21] migration: allow cancel to unpause
Date: Mon, 23 Oct 2017 18:07:50 +0200	[thread overview]
Message-ID: <20171023160800.20540-12-quintela@redhat.com> (raw)
In-Reply-To: <20171023160800.20540-1-quintela@redhat.com>

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

If a migration_cancel is issued during the new paused state,
kick the pause_sem to get to unpause so it can cancel.

Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 migration/migration.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/migration/migration.c b/migration/migration.c
index 90bfdc3a7c..b523d8f215 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -1114,6 +1114,10 @@ static void migrate_fd_cancel(MigrationState *s)
         if (!migration_is_setup_or_active(old_state)) {
             break;
         }
+        /* If the migration is paused, kick it out of the pause */
+        if (old_state == MIGRATION_STATUS_PRE_SWITCHOVER) {
+            qemu_sem_post(&s->pause_sem);
+        }
         migrate_set_state(&s->state, old_state, MIGRATION_STATUS_CANCELLING);
     } while (s->state != MIGRATION_STATUS_CANCELLING);
 
-- 
2.13.6

  parent reply	other threads:[~2017-10-23 16:08 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-23 16:07 [Qemu-devel] [PULL 00/21] Migration pull request Juan Quintela
2017-10-23 16:07 ` [Qemu-devel] [PULL 01/21] migration: Fix migrate_test_apply for multifd parameters Juan Quintela
2017-10-23 16:07 ` [Qemu-devel] [PULL 02/21] migratiom: Remove max_item_age parameter Juan Quintela
2017-10-23 16:07 ` [Qemu-devel] [PULL 03/21] migration: Make cache size elements use the right types Juan Quintela
2017-10-23 16:07 ` [Qemu-devel] [PULL 04/21] migration: Move xbzrle cache resize error handling to xbzrle_cache_resize Juan Quintela
2017-10-23 16:07 ` [Qemu-devel] [PULL 05/21] migration: Make cache_init() take an error parameter Juan Quintela
2017-10-23 16:07 ` [Qemu-devel] [PULL 06/21] migration: Add 'pause-before-switchover' capability Juan Quintela
2017-10-23 16:07 ` [Qemu-devel] [PULL 07/21] migration: Add 'pre-switchover' and 'device' statuses Juan Quintela
2017-10-23 16:07 ` [Qemu-devel] [PULL 08/21] migration: Wait for semaphore before completing migration Juan Quintela
2017-10-23 16:07 ` [Qemu-devel] [PULL 09/21] migration: migrate-continue Juan Quintela
2017-10-23 16:07 ` [Qemu-devel] [PULL 10/21] migrate: HMP migate_continue Juan Quintela
2017-10-23 16:07 ` Juan Quintela [this message]
2017-10-23 16:07 ` [Qemu-devel] [PULL 12/21] migration: pause-before-switchover for postcopy Juan Quintela
2017-10-23 16:07 ` [Qemu-devel] [PULL 13/21] migration: provide ram_state_init() Juan Quintela
2017-10-23 16:07 ` [Qemu-devel] [PULL 14/21] migration: provide ram_state_cleanup Juan Quintela
2017-10-23 16:07 ` [Qemu-devel] [PULL 15/21] migration: clean up xbzrle cache init/destroy Juan Quintela
2017-10-23 16:07 ` [Qemu-devel] [PULL 16/21] migration: new ram_init_bitmaps() Juan Quintela
2017-10-23 16:07 ` [Qemu-devel] [PULL 17/21] migration: postcopy_place_page factoring out Juan Quintela
2017-10-23 16:07 ` [Qemu-devel] [PULL 18/21] migration: introduce qemu_ufd_copy_ioctl helper Juan Quintela
2017-10-23 16:07 ` [Qemu-devel] [PULL 19/21] migration: add bitmap for received page Juan Quintela
2017-10-23 16:07 ` [Qemu-devel] [PULL 20/21] qapi: Fix grammar in x-multifd-page-count descriptions Juan Quintela
2017-10-23 16:08 ` [Qemu-devel] [PULL 21/21] migration: Improve migration thread error handling Juan Quintela
2017-10-25 15:38 ` [Qemu-devel] [PULL 00/21] Migration pull request Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171023160800.20540-12-quintela@redhat.com \
    --to=quintela@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).