From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: dgilbert@redhat.com, lvivier@redhat.com, peterx@redhat.com
Subject: [Qemu-devel] [PULL 06/21] migration: Add 'pause-before-switchover' capability
Date: Mon, 23 Oct 2017 18:07:45 +0200 [thread overview]
Message-ID: <20171023160800.20540-7-quintela@redhat.com> (raw)
In-Reply-To: <20171023160800.20540-1-quintela@redhat.com>
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
When 'pause-before-switchover' is enabled, the outgoing migration
will pause before invalidating the block devices and serializing
the device state.
At this point the management layer gets the chance to clean up any
device jobs or other device users before the migration completes.
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
migration/migration.c | 10 ++++++++++
migration/migration.h | 1 +
qapi/migration.json | 5 ++++-
3 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/migration/migration.c b/migration/migration.c
index 3feffb5e26..c041ec7aed 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -1511,6 +1511,16 @@ bool migrate_use_multifd(void)
return s->enabled_capabilities[MIGRATION_CAPABILITY_X_MULTIFD];
}
+bool migrate_pause_before_switchover(void)
+{
+ MigrationState *s;
+
+ s = migrate_get_current();
+
+ return s->enabled_capabilities[
+ MIGRATION_CAPABILITY_PAUSE_BEFORE_SWITCHOVER];
+}
+
int migrate_multifd_channels(void)
{
MigrationState *s;
diff --git a/migration/migration.h b/migration/migration.h
index b83cceadc4..969866303e 100644
--- a/migration/migration.h
+++ b/migration/migration.h
@@ -177,6 +177,7 @@ bool migrate_zero_blocks(void);
bool migrate_auto_converge(void);
bool migrate_use_multifd(void);
+bool migrate_pause_before_switchover(void);
int migrate_multifd_channels(void);
int migrate_multifd_page_count(void);
diff --git a/qapi/migration.json b/qapi/migration.json
index f8b365e3f5..4960231ba2 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@@ -341,6 +341,9 @@
# @return-path: If enabled, migration will use the return path even
# for precopy. (since 2.10)
#
+# @pause-before-switchover: Pause outgoing migration before serialising device
+# state and before disabling block IO (since 2.11)
+#
# @x-multifd: Use more than one fd for migration (since 2.11)
#
# Since: 1.2
@@ -348,7 +351,7 @@
{ 'enum': 'MigrationCapability',
'data': ['xbzrle', 'rdma-pin-all', 'auto-converge', 'zero-blocks',
'compress', 'events', 'postcopy-ram', 'x-colo', 'release-ram',
- 'block', 'return-path', 'x-multifd' ] }
+ 'block', 'return-path', 'pause-before-switchover', 'x-multifd' ] }
##
# @MigrationCapabilityStatus:
--
2.13.6
next prev parent reply other threads:[~2017-10-23 16:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-23 16:07 [Qemu-devel] [PULL 00/21] Migration pull request Juan Quintela
2017-10-23 16:07 ` [Qemu-devel] [PULL 01/21] migration: Fix migrate_test_apply for multifd parameters Juan Quintela
2017-10-23 16:07 ` [Qemu-devel] [PULL 02/21] migratiom: Remove max_item_age parameter Juan Quintela
2017-10-23 16:07 ` [Qemu-devel] [PULL 03/21] migration: Make cache size elements use the right types Juan Quintela
2017-10-23 16:07 ` [Qemu-devel] [PULL 04/21] migration: Move xbzrle cache resize error handling to xbzrle_cache_resize Juan Quintela
2017-10-23 16:07 ` [Qemu-devel] [PULL 05/21] migration: Make cache_init() take an error parameter Juan Quintela
2017-10-23 16:07 ` Juan Quintela [this message]
2017-10-23 16:07 ` [Qemu-devel] [PULL 07/21] migration: Add 'pre-switchover' and 'device' statuses Juan Quintela
2017-10-23 16:07 ` [Qemu-devel] [PULL 08/21] migration: Wait for semaphore before completing migration Juan Quintela
2017-10-23 16:07 ` [Qemu-devel] [PULL 09/21] migration: migrate-continue Juan Quintela
2017-10-23 16:07 ` [Qemu-devel] [PULL 10/21] migrate: HMP migate_continue Juan Quintela
2017-10-23 16:07 ` [Qemu-devel] [PULL 11/21] migration: allow cancel to unpause Juan Quintela
2017-10-23 16:07 ` [Qemu-devel] [PULL 12/21] migration: pause-before-switchover for postcopy Juan Quintela
2017-10-23 16:07 ` [Qemu-devel] [PULL 13/21] migration: provide ram_state_init() Juan Quintela
2017-10-23 16:07 ` [Qemu-devel] [PULL 14/21] migration: provide ram_state_cleanup Juan Quintela
2017-10-23 16:07 ` [Qemu-devel] [PULL 15/21] migration: clean up xbzrle cache init/destroy Juan Quintela
2017-10-23 16:07 ` [Qemu-devel] [PULL 16/21] migration: new ram_init_bitmaps() Juan Quintela
2017-10-23 16:07 ` [Qemu-devel] [PULL 17/21] migration: postcopy_place_page factoring out Juan Quintela
2017-10-23 16:07 ` [Qemu-devel] [PULL 18/21] migration: introduce qemu_ufd_copy_ioctl helper Juan Quintela
2017-10-23 16:07 ` [Qemu-devel] [PULL 19/21] migration: add bitmap for received page Juan Quintela
2017-10-23 16:07 ` [Qemu-devel] [PULL 20/21] qapi: Fix grammar in x-multifd-page-count descriptions Juan Quintela
2017-10-23 16:08 ` [Qemu-devel] [PULL 21/21] migration: Improve migration thread error handling Juan Quintela
2017-10-25 15:38 ` [Qemu-devel] [PULL 00/21] Migration pull request Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171023160800.20540-7-quintela@redhat.com \
--to=quintela@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lvivier@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).