From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37430) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e7KQP-0008UN-IZ for qemu-devel@nongnu.org; Wed, 25 Oct 2017 08:04:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e7KQL-00085Q-7q for qemu-devel@nongnu.org; Wed, 25 Oct 2017 08:04:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32898) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e7KQK-00083j-Uv for qemu-devel@nongnu.org; Wed, 25 Oct 2017 08:04:41 -0400 Date: Wed, 25 Oct 2017 14:04:35 +0200 From: Eduardo Otubo Message-ID: <20171025120435.GD10290@vader> References: <20171023151310.6462-1-vadim.galitsyn@profitbricks.com> <20171023151310.6462-3-vadim.galitsyn@profitbricks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20171023151310.6462-3-vadim.galitsyn@profitbricks.com> Subject: Re: [Qemu-devel] [PATCH 2/4] hmp: introduce 'writeconfig' command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vadim Galitsyn Cc: Markus Armbruster , Eric Blake , "Dr . David Alan Gilbert" , qemu-devel@nongnu.org, Eduardo Otubo On Mon, Oct 23, 2017 at 05:13:08PM +0200, Vadim Galitsyn wrote: > Add 'writeconfig' command for HMP monitor. This command is a > sibling of QMP command 'writeconfig'. > > This is a simple way to keep track of current state of VM > after series of hotplugs and/or hotunplugs of different devices. > > Signed-off-by: Vadim Galitsyn > Signed-off-by: Eduardo Otubo > Cc: Dr. David Alan Gilbert > Cc: qemu-devel@nongnu.org > --- > hmp.h | 1 + > hmp.c | 9 +++++++++ > hmp-commands.hx | 17 +++++++++++++++++ > 3 files changed, 27 insertions(+) > > diff --git a/hmp.h b/hmp.h > index 3605003e4c..2730b7f7b9 100644 > --- a/hmp.h > +++ b/hmp.h > @@ -146,5 +146,6 @@ void hmp_info_ramblock(Monitor *mon, const QDict *qdict); > void hmp_hotpluggable_cpus(Monitor *mon, const QDict *qdict); > void hmp_info_vm_generation_id(Monitor *mon, const QDict *qdict); > void hmp_info_memory_size_summary(Monitor *mon, const QDict *qdict); > +void hmp_writeconfig(Monitor *mon, const QDict *qdict); > > #endif > diff --git a/hmp.c b/hmp.c > index ec61329ebb..20af8ab870 100644 > --- a/hmp.c > +++ b/hmp.c > @@ -2901,3 +2901,12 @@ void hmp_info_memory_size_summary(Monitor *mon, const QDict *qdict) > } > hmp_handle_error(mon, &err); > } > + > +void hmp_writeconfig(Monitor *mon, const QDict *qdict) > +{ > + const char *file = qdict_get_str(qdict, "file"); > + Error *err = NULL; > + > + qmp_writeconfig(file, &err); > + hmp_handle_error(mon, &err); > +} > diff --git a/hmp-commands.hx b/hmp-commands.hx > index 1941e19932..98a3dc4b66 100644 > --- a/hmp-commands.hx > +++ b/hmp-commands.hx > @@ -1858,6 +1858,23 @@ ETEXI > .sub_table = info_cmds, > }, > > + { > + .name = "writeconfig", > + .args_type = "file:F", > + .params = "file", > + .help = "dump current configuration into specified file", > + .cmd = hmp_writeconfig, > + }, > + > +STEXI > +@item writeconfig @var{file} > +@findex writeconfig > +Dump current configuration into specified @var{file}. > +@example > +(qemu) writeconfig /tmp/qemu.conf > +@end example > +ETEXI > + > STEXI > @end table > ETEXI > -- > 2.13.1.394.g41dd433 > > Reviewed-by: Eduardo Otubo -- Eduardo Otubo