From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: [Qemu-devel] [PULL 04/11] target/arm: Don't set INSN_ARM_BE32 for CONFIG_USER_ONLY
Date: Wed, 25 Oct 2017 14:30:49 +0200 [thread overview]
Message-ID: <20171025123056.3165-5-richard.henderson@linaro.org> (raw)
In-Reply-To: <20171025123056.3165-1-richard.henderson@linaro.org>
This matches translator behaviour in arm_lduw_code.
Fixes: https://bugs.launchpad.net/qemu/+bug/1724485
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/cpu.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index 82dad0b721..a92d86faa0 100644
--- a/target/arm/cpu.c
+++ b/target/arm/cpu.c
@@ -477,6 +477,7 @@ static void arm_disas_set_info(CPUState *cpu, disassemble_info *info)
{
ARMCPU *ac = ARM_CPU(cpu);
CPUARMState *env = &ac->env;
+ bool sctlr_b;
if (is_a64(env)) {
/* We might not be compiled with the A64 disassembler
@@ -491,7 +492,9 @@ static void arm_disas_set_info(CPUState *cpu, disassemble_info *info)
} else {
info->print_insn = print_insn_arm;
}
- if (bswap_code(arm_sctlr_b(env))) {
+
+ sctlr_b = arm_sctlr_b(env);
+ if (bswap_code(sctlr_b)) {
#ifdef TARGET_WORDS_BIGENDIAN
info->endian = BFD_ENDIAN_LITTLE;
#else
@@ -499,9 +502,11 @@ static void arm_disas_set_info(CPUState *cpu, disassemble_info *info)
#endif
}
info->flags &= ~INSN_ARM_BE32;
- if (arm_sctlr_b(env)) {
+#ifndef CONFIG_USER_ONLY
+ if (sctlr_b) {
info->flags |= INSN_ARM_BE32;
}
+#endif
}
uint64_t arm_cpu_mp_affinity(int idx, uint8_t clustersz)
--
2.13.6
next prev parent reply other threads:[~2017-10-25 12:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 12:30 [Qemu-devel] [PULL 00/11] Disassembler patches Richard Henderson
2017-10-25 12:30 ` [Qemu-devel] [PULL 01/11] target/i386: Convert to disas_set_info hook Richard Henderson
2017-10-25 12:30 ` [Qemu-devel] [PULL 02/11] target/ppc: " Richard Henderson
2017-10-25 12:30 ` [Qemu-devel] [PULL 03/11] target/arm: Move BE32 disassembler fixup Richard Henderson
2017-10-25 12:30 ` Richard Henderson [this message]
2017-10-25 12:30 ` [Qemu-devel] [PULL 05/11] disas: Remove unused flags arguments Richard Henderson
2017-10-25 12:30 ` [Qemu-devel] [PULL 06/11] disas: Support the Capstone disassembler library Richard Henderson
2017-10-25 12:30 ` [Qemu-devel] [PULL 07/11] i386: Support Capstone in disas_set_info Richard Henderson
2017-10-25 12:30 ` [Qemu-devel] [PULL 08/11] arm: " Richard Henderson
2017-10-25 12:30 ` [Qemu-devel] [PULL 09/11] ppc: " Richard Henderson
2017-10-25 12:30 ` [Qemu-devel] [PULL 10/11] disas: Remove monitor_disas_is_physical Richard Henderson
2017-10-25 12:30 ` [Qemu-devel] [PULL 11/11] disas: Add capstone as submodule Richard Henderson
2017-10-25 12:43 ` [Qemu-devel] [PULL 00/11] Disassembler patches no-reply
2017-10-26 6:07 ` Peter Maydell
2017-10-26 6:16 ` Peter Maydell
2017-10-26 7:06 ` Daniel P. Berrange
2017-10-26 7:21 ` Peter Maydell
2017-10-26 10:04 ` Richard Henderson
2017-10-26 10:06 ` Daniel P. Berrange
2017-10-26 13:29 ` Philippe Mathieu-Daudé
2017-10-26 13:50 ` Daniel P. Berrange
2017-10-26 14:25 ` Peter Maydell
2017-10-26 7:10 ` Richard Henderson
2017-10-27 15:07 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171025123056.3165-5-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).