* [Qemu-devel] [PATCH qemu v2] machine: Polish -machine xxx,help
@ 2017-10-26 1:41 Alexey Kardashevskiy
2017-12-15 4:47 ` Alexey Kardashevskiy
2018-02-10 7:07 ` Michael Tokarev
0 siblings, 2 replies; 6+ messages in thread
From: Alexey Kardashevskiy @ 2017-10-26 1:41 UTC (permalink / raw)
To: qemu-devel; +Cc: Alexey Kardashevskiy
The "-machine xxx,help" prints kernel-irqchip possible values as
"OnOffSplit", this adds separators to the printed line.
Also, since only lower case letters are specified in qapi/common.json,
this changes the letter cases too.
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
aik@fstn1-p1:~$ ./qemu-system-ppc64 -machine pseries,help 2>&1 | grep kernel-irqchip
Was:
pseries-2.11.kernel-irqchip=OnOffSplit (Configure KVM in-kernel irqchip)
Now:
pseries-2.11.kernel-irqchip=on|off|split (Configure KVM in-kernel irqchip)
---
hw/core/machine.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/core/machine.c b/hw/core/machine.c
index 36c2fb069c..bd3db14e12 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -506,7 +506,7 @@ static void machine_class_init(ObjectClass *oc, void *data)
object_class_property_set_description(oc, "accel",
"Accelerator list", &error_abort);
- object_class_property_add(oc, "kernel-irqchip", "OnOffSplit",
+ object_class_property_add(oc, "kernel-irqchip", "on|off|split",
NULL, machine_set_kernel_irqchip,
NULL, NULL, &error_abort);
object_class_property_set_description(oc, "kernel-irqchip",
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH qemu v2] machine: Polish -machine xxx,help
2017-10-26 1:41 [Qemu-devel] [PATCH qemu v2] machine: Polish -machine xxx,help Alexey Kardashevskiy
@ 2017-12-15 4:47 ` Alexey Kardashevskiy
2018-01-29 5:03 ` Alexey Kardashevskiy
2018-02-10 7:07 ` Michael Tokarev
1 sibling, 1 reply; 6+ messages in thread
From: Alexey Kardashevskiy @ 2017-12-15 4:47 UTC (permalink / raw)
To: qemu-devel
On 26/10/17 12:41, Alexey Kardashevskiy wrote:
> The "-machine xxx,help" prints kernel-irqchip possible values as
> "OnOffSplit", this adds separators to the printed line.
>
> Also, since only lower case letters are specified in qapi/common.json,
> this changes the letter cases too.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
ping?
> ---
>
> aik@fstn1-p1:~$ ./qemu-system-ppc64 -machine pseries,help 2>&1 | grep kernel-irqchip
>
> Was:
> pseries-2.11.kernel-irqchip=OnOffSplit (Configure KVM in-kernel irqchip)
>
> Now:
> pseries-2.11.kernel-irqchip=on|off|split (Configure KVM in-kernel irqchip)
> ---
> hw/core/machine.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index 36c2fb069c..bd3db14e12 100644
> --- a/hw/core/machine.c
> +++ b/hw/core/machine.c
> @@ -506,7 +506,7 @@ static void machine_class_init(ObjectClass *oc, void *data)
> object_class_property_set_description(oc, "accel",
> "Accelerator list", &error_abort);
>
> - object_class_property_add(oc, "kernel-irqchip", "OnOffSplit",
> + object_class_property_add(oc, "kernel-irqchip", "on|off|split",
> NULL, machine_set_kernel_irqchip,
> NULL, NULL, &error_abort);
> object_class_property_set_description(oc, "kernel-irqchip",
>
--
Alexey
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH qemu v2] machine: Polish -machine xxx,help
2017-12-15 4:47 ` Alexey Kardashevskiy
@ 2018-01-29 5:03 ` Alexey Kardashevskiy
2018-02-02 2:45 ` Alexey Kardashevskiy
0 siblings, 1 reply; 6+ messages in thread
From: Alexey Kardashevskiy @ 2018-01-29 5:03 UTC (permalink / raw)
To: qemu-devel
On 15/12/17 15:47, Alexey Kardashevskiy wrote:
> On 26/10/17 12:41, Alexey Kardashevskiy wrote:
>> The "-machine xxx,help" prints kernel-irqchip possible values as
>> "OnOffSplit", this adds separators to the printed line.
>>
>> Also, since only lower case letters are specified in qapi/common.json,
>> this changes the letter cases too.
>>
>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>
> ping?
anyone?
>
>
>> ---
>>
>> aik@fstn1-p1:~$ ./qemu-system-ppc64 -machine pseries,help 2>&1 | grep kernel-irqchip
>>
>> Was:
>> pseries-2.11.kernel-irqchip=OnOffSplit (Configure KVM in-kernel irqchip)
>>
>> Now:
>> pseries-2.11.kernel-irqchip=on|off|split (Configure KVM in-kernel irqchip)
>> ---
>> hw/core/machine.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/core/machine.c b/hw/core/machine.c
>> index 36c2fb069c..bd3db14e12 100644
>> --- a/hw/core/machine.c
>> +++ b/hw/core/machine.c
>> @@ -506,7 +506,7 @@ static void machine_class_init(ObjectClass *oc, void *data)
>> object_class_property_set_description(oc, "accel",
>> "Accelerator list", &error_abort);
>>
>> - object_class_property_add(oc, "kernel-irqchip", "OnOffSplit",
>> + object_class_property_add(oc, "kernel-irqchip", "on|off|split",
>> NULL, machine_set_kernel_irqchip,
>> NULL, NULL, &error_abort);
>> object_class_property_set_description(oc, "kernel-irqchip",
>>
>
>
--
Alexey
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH qemu v2] machine: Polish -machine xxx,help
2018-01-29 5:03 ` Alexey Kardashevskiy
@ 2018-02-02 2:45 ` Alexey Kardashevskiy
2018-02-08 4:27 ` Alexey Kardashevskiy
0 siblings, 1 reply; 6+ messages in thread
From: Alexey Kardashevskiy @ 2018-02-02 2:45 UTC (permalink / raw)
To: qemu-devel, QEMU Trivial
On 29/01/18 16:03, Alexey Kardashevskiy wrote:
> On 15/12/17 15:47, Alexey Kardashevskiy wrote:
>> On 26/10/17 12:41, Alexey Kardashevskiy wrote:
>>> The "-machine xxx,help" prints kernel-irqchip possible values as
>>> "OnOffSplit", this adds separators to the printed line.
>>>
>>> Also, since only lower case letters are specified in qapi/common.json,
>>> this changes the letter cases too.
>>>
>>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>>
>> ping?
>
>
> anyone?
Let's try trivial list now :)
>
>>
>>
>>> ---
>>>
>>> aik@fstn1-p1:~$ ./qemu-system-ppc64 -machine pseries,help 2>&1 | grep kernel-irqchip
>>>
>>> Was:
>>> pseries-2.11.kernel-irqchip=OnOffSplit (Configure KVM in-kernel irqchip)
>>>
>>> Now:
>>> pseries-2.11.kernel-irqchip=on|off|split (Configure KVM in-kernel irqchip)
>>> ---
>>> hw/core/machine.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/hw/core/machine.c b/hw/core/machine.c
>>> index 36c2fb069c..bd3db14e12 100644
>>> --- a/hw/core/machine.c
>>> +++ b/hw/core/machine.c
>>> @@ -506,7 +506,7 @@ static void machine_class_init(ObjectClass *oc, void *data)
>>> object_class_property_set_description(oc, "accel",
>>> "Accelerator list", &error_abort);
>>>
>>> - object_class_property_add(oc, "kernel-irqchip", "OnOffSplit",
>>> + object_class_property_add(oc, "kernel-irqchip", "on|off|split",
>>> NULL, machine_set_kernel_irqchip,
>>> NULL, NULL, &error_abort);
>>> object_class_property_set_description(oc, "kernel-irqchip",
>>>
>>
>>
>
>
--
Alexey
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH qemu v2] machine: Polish -machine xxx,help
2018-02-02 2:45 ` Alexey Kardashevskiy
@ 2018-02-08 4:27 ` Alexey Kardashevskiy
0 siblings, 0 replies; 6+ messages in thread
From: Alexey Kardashevskiy @ 2018-02-08 4:27 UTC (permalink / raw)
To: qemu-devel, QEMU Trivial
On 02/02/18 13:45, Alexey Kardashevskiy wrote:
> On 29/01/18 16:03, Alexey Kardashevskiy wrote:
>> On 15/12/17 15:47, Alexey Kardashevskiy wrote:
>>> On 26/10/17 12:41, Alexey Kardashevskiy wrote:
>>>> The "-machine xxx,help" prints kernel-irqchip possible values as
>>>> "OnOffSplit", this adds separators to the printed line.
>>>>
>>>> Also, since only lower case letters are specified in qapi/common.json,
>>>> this changes the letter cases too.
>>>>
>>>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>>>
>>> ping?
>>
>>
>> anyone?
>
> Let's try trivial list now :)
And ping again :)
>
>
>>
>>>
>>>
>>>> ---
>>>>
>>>> aik@fstn1-p1:~$ ./qemu-system-ppc64 -machine pseries,help 2>&1 | grep kernel-irqchip
>>>>
>>>> Was:
>>>> pseries-2.11.kernel-irqchip=OnOffSplit (Configure KVM in-kernel irqchip)
>>>>
>>>> Now:
>>>> pseries-2.11.kernel-irqchip=on|off|split (Configure KVM in-kernel irqchip)
>>>> ---
>>>> hw/core/machine.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/hw/core/machine.c b/hw/core/machine.c
>>>> index 36c2fb069c..bd3db14e12 100644
>>>> --- a/hw/core/machine.c
>>>> +++ b/hw/core/machine.c
>>>> @@ -506,7 +506,7 @@ static void machine_class_init(ObjectClass *oc, void *data)
>>>> object_class_property_set_description(oc, "accel",
>>>> "Accelerator list", &error_abort);
>>>>
>>>> - object_class_property_add(oc, "kernel-irqchip", "OnOffSplit",
>>>> + object_class_property_add(oc, "kernel-irqchip", "on|off|split",
>>>> NULL, machine_set_kernel_irqchip,
>>>> NULL, NULL, &error_abort);
>>>> object_class_property_set_description(oc, "kernel-irqchip",
>>>>
>>>
>>>
>>
>>
>
>
--
Alexey
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH qemu v2] machine: Polish -machine xxx,help
2017-10-26 1:41 [Qemu-devel] [PATCH qemu v2] machine: Polish -machine xxx,help Alexey Kardashevskiy
2017-12-15 4:47 ` Alexey Kardashevskiy
@ 2018-02-10 7:07 ` Michael Tokarev
1 sibling, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2018-02-10 7:07 UTC (permalink / raw)
To: Alexey Kardashevskiy, qemu-devel, QEMU Trivial
26.10.2017 04:41, Alexey Kardashevskiy пишет:
> The "-machine xxx,help" prints kernel-irqchip possible values as
> "OnOffSplit", this adds separators to the printed line.
Applied to -trivial, thanks, and please excuse us for the very long delay!
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-02-10 7:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-26 1:41 [Qemu-devel] [PATCH qemu v2] machine: Polish -machine xxx,help Alexey Kardashevskiy
2017-12-15 4:47 ` Alexey Kardashevskiy
2018-01-29 5:03 ` Alexey Kardashevskiy
2018-02-02 2:45 ` Alexey Kardashevskiy
2018-02-08 4:27 ` Alexey Kardashevskiy
2018-02-10 7:07 ` Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).