From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org, lvivier@redhat.com, peterx@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 3/5] migration: No need to return the size of the cache
Date: Thu, 26 Oct 2017 13:37:55 +0100 [thread overview]
Message-ID: <20171026123754.GB2585@work-vm> (raw)
In-Reply-To: <87mv4emlpk.fsf@secure.laptop>
* Juan Quintela (quintela@redhat.com) wrote:
> "Dr. David Alan Gilbert" <dgilbert@redhat.com> wrote:
> > * Juan Quintela (quintela@redhat.com) wrote:
> >> After the previous commits, we make sure that the value passed is
> >> right, or we just drop an error. So now we return if there is one
> >> error or we have setup correctly the value passed.
> >>
> >> Signed-off-by: Juan Quintela <quintela@redhat.com>
>
> > OK, this shares the same oddity as the original which is
> > XBZRLE.cache = NULL is not an error.
> >
> > but, since that is the same as the original;
>
> Hi
>
> It is a normal case. You can change the cache size in the middle of
> migration or outside migration.
>
> If we are not in the middle of migration, cache is NULL.
Ah OK, so yes,
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Later, Juan.
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2017-10-26 12:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 5:48 [Qemu-devel] [PATCH v3 0/5] Make xbzrle_cache_size a migration parameter Juan Quintela
2017-10-25 5:48 ` [Qemu-devel] [PATCH v3 1/5] migration: Make sure that we pass the right cache size Juan Quintela
2017-10-25 5:48 ` [Qemu-devel] [PATCH v3 2/5] migration: Don't play games with the requested " Juan Quintela
2017-10-25 5:48 ` [Qemu-devel] [PATCH v3 3/5] migration: No need to return the size of the cache Juan Quintela
2017-10-25 17:28 ` Dr. David Alan Gilbert
2017-10-26 7:07 ` Juan Quintela
2017-10-26 12:37 ` Dr. David Alan Gilbert [this message]
2017-10-25 5:48 ` [Qemu-devel] [PATCH v3 4/5] migration: Make xbzrle_cache_size a migration parameter Juan Quintela
2017-10-25 5:48 ` [Qemu-devel] [PATCH v3 5/5] migration: [RFC] Use proper types in json Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171026123754.GB2585@work-vm \
--to=dgilbert@redhat.com \
--cc=lvivier@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).