From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49127) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e7hQH-0005YK-8O for qemu-devel@nongnu.org; Thu, 26 Oct 2017 08:38:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e7hQE-0006PB-2z for qemu-devel@nongnu.org; Thu, 26 Oct 2017 08:38:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44958) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e7hQD-0006MS-S0 for qemu-devel@nongnu.org; Thu, 26 Oct 2017 08:38:05 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D200A7E384 for ; Thu, 26 Oct 2017 12:38:03 +0000 (UTC) Date: Thu, 26 Oct 2017 13:37:55 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20171026123754.GB2585@work-vm> References: <20171025054842.24883-1-quintela@redhat.com> <20171025054842.24883-4-quintela@redhat.com> <20171025172835.GD2484@work-vm> <87mv4emlpk.fsf@secure.laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87mv4emlpk.fsf@secure.laptop> Subject: Re: [Qemu-devel] [PATCH v3 3/5] migration: No need to return the size of the cache List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org, lvivier@redhat.com, peterx@redhat.com * Juan Quintela (quintela@redhat.com) wrote: > "Dr. David Alan Gilbert" wrote: > > * Juan Quintela (quintela@redhat.com) wrote: > >> After the previous commits, we make sure that the value passed is > >> right, or we just drop an error. So now we return if there is one > >> error or we have setup correctly the value passed. > >> > >> Signed-off-by: Juan Quintela > > > OK, this shares the same oddity as the original which is > > XBZRLE.cache = NULL is not an error. > > > > but, since that is the same as the original; > > Hi > > It is a normal case. You can change the cache size in the middle of > migration or outside migration. > > If we are not in the middle of migration, cache is NULL. Ah OK, so yes, Reviewed-by: Dr. David Alan Gilbert > Later, Juan. -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK