qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: sameeh@daynix.com, yan@daynix.com, daniel@daynix.com
Subject: [Qemu-devel] [PATCH 0/6] qga: add support for re-opening channel on error
Date: Thu, 26 Oct 2017 18:30:48 -0500	[thread overview]
Message-ID: <20171026233054.21133-1-mdroth@linux.vnet.ibm.com> (raw)

The following patches are also available at:
  https://github.com/mdroth/qemu/commits/qga-retry-path

This series adds a --retry-path option to qemu-ga to allow the agent
to periodically re-attempt opening a channel if the channel is not
yet present (e.g. qemu-ga is installed before virtio-serial drivers)
or if the channel encounters an error that might be recoverable (e.g.
the channel is hot unplugged/plugged).

This functionality is already possible via init systems like systemd (and
is already set up that way on Fedora), but we implement this option
to handle other OSs like Windows (where this was originally reported as
a problem).

PATCH 1-3 implement various refactorings that more clearly encapsulate
the agent's lifecycle into:

 a) config parsing (via main())
 b) initializing the agent (via initialize_agent())
 c) starting the agent (via run_agent())
 d) stopping the agent (via stop_agent())
 e) cleaning up the agent (via cleanup_agent())
 f) cleaning up the config (via main())

PATCH 4 implements the actual --retry-path option, which simply wraps
run_agent() in a continuous loop until the agent is explicitly told
to exit.

 qga/channel-win32.c       |   3 +-
 qga/installer/qemu-ga.wxs |   2 +-
 qga/main.c                | 205 ++++++++++++++++++++++++++++++++++++++++++++++++------------------------
 3 files changed, 141 insertions(+), 69 deletions(-)

             reply	other threads:[~2017-10-26 23:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-26 23:30 Michael Roth [this message]
2017-10-26 23:30 ` [Qemu-devel] [PATCH 1/6] qga: group agent init/cleanup init separate routines Michael Roth
2017-10-26 23:30 ` [Qemu-devel] [PATCH 2/6] qga: hang GAConfig/socket_activation off of GAState global Michael Roth
2017-10-26 23:30 ` [Qemu-devel] [PATCH 3/6] qga: move w32 service handling out of run_agent() Michael Roth
2017-10-26 23:30 ` [Qemu-devel] [PATCH 4/6] qga: add --retry-path option for re-initializing channel on failure Michael Roth
2017-10-26 23:30 ` [Qemu-devel] [PATCH 5/6] qga-win: install service with --retry-path set by default Michael Roth
2017-10-26 23:30 ` [Qemu-devel] [PATCH 6/6] qga-win: report specific error when failing to open channel Michael Roth
2017-10-26 23:38 ` [Qemu-devel] [PATCH 0/6] qga: add support for re-opening channel on error no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171026233054.21133-1-mdroth@linux.vnet.ibm.com \
    --to=mdroth@linux.vnet.ibm.com \
    --cc=daniel@daynix.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sameeh@daynix.com \
    --cc=yan@daynix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).