From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: sameeh@daynix.com, yan@daynix.com, daniel@daynix.com
Subject: [Qemu-devel] [PATCH 5/6] qga-win: install service with --retry-path set by default
Date: Thu, 26 Oct 2017 18:30:53 -0500 [thread overview]
Message-ID: <20171026233054.21133-6-mdroth@linux.vnet.ibm.com> (raw)
In-Reply-To: <20171026233054.21133-1-mdroth@linux.vnet.ibm.com>
It's nicer from a management perspective that the agent can survive
hotplug/unplug of the channel device, or be started prior to the
installation of the channel device's driver without and still be able
to resume normal function afterward. On linux there are alternatives
like systemd to support this, but on w32 --retry-path is the only
option so it makes sense to set it by default when installed as a
w32 service.
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---
qga/installer/qemu-ga.wxs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs
index 5af11627f8..fb2273507f 100644
--- a/qga/installer/qemu-ga.wxs
+++ b/qga/installer/qemu-ga.wxs
@@ -78,7 +78,7 @@
Account="LocalSystem"
ErrorControl="ignore"
Interactive="no"
- Arguments="-d"
+ Arguments="-d --retry-path"
>
</ServiceInstall>
<ServiceControl Id="StartService" Start="install" Stop="both" Remove="uninstall" Name="QEMU-GA" Wait="no" />
--
2.11.0
next prev parent reply other threads:[~2017-10-26 23:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 23:30 [Qemu-devel] [PATCH 0/6] qga: add support for re-opening channel on error Michael Roth
2017-10-26 23:30 ` [Qemu-devel] [PATCH 1/6] qga: group agent init/cleanup init separate routines Michael Roth
2017-10-26 23:30 ` [Qemu-devel] [PATCH 2/6] qga: hang GAConfig/socket_activation off of GAState global Michael Roth
2017-10-26 23:30 ` [Qemu-devel] [PATCH 3/6] qga: move w32 service handling out of run_agent() Michael Roth
2017-10-26 23:30 ` [Qemu-devel] [PATCH 4/6] qga: add --retry-path option for re-initializing channel on failure Michael Roth
2017-10-26 23:30 ` Michael Roth [this message]
2017-10-26 23:30 ` [Qemu-devel] [PATCH 6/6] qga-win: report specific error when failing to open channel Michael Roth
2017-10-26 23:38 ` [Qemu-devel] [PATCH 0/6] qga: add support for re-opening channel on error no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171026233054.21133-6-mdroth@linux.vnet.ibm.com \
--to=mdroth@linux.vnet.ibm.com \
--cc=daniel@daynix.com \
--cc=qemu-devel@nongnu.org \
--cc=sameeh@daynix.com \
--cc=yan@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).