From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: sameeh@daynix.com, yan@daynix.com, daniel@daynix.com
Subject: [Qemu-devel] [PATCH 6/6] qga-win: report specific error when failing to open channel
Date: Thu, 26 Oct 2017 18:30:54 -0500 [thread overview]
Message-ID: <20171026233054.21133-7-mdroth@linux.vnet.ibm.com> (raw)
In-Reply-To: <20171026233054.21133-1-mdroth@linux.vnet.ibm.com>
Useful in general, but especially now that errors might occur more
frequently with --retry-path set.
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---
qga/channel-win32.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/qga/channel-win32.c b/qga/channel-win32.c
index 7e6dc4d26f..335542f748 100644
--- a/qga/channel-win32.c
+++ b/qga/channel-win32.c
@@ -302,7 +302,8 @@ static gboolean ga_channel_open(GAChannel *c, GAChannelMethod method,
OPEN_EXISTING,
FILE_FLAG_NO_BUFFERING | FILE_FLAG_OVERLAPPED, NULL);
if (c->handle == INVALID_HANDLE_VALUE) {
- g_critical("error opening path %s", newpath);
+ g_critical("error opening path %s: %s", newpath,
+ g_win32_error_message(GetLastError()));
return false;
}
--
2.11.0
next prev parent reply other threads:[~2017-10-26 23:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 23:30 [Qemu-devel] [PATCH 0/6] qga: add support for re-opening channel on error Michael Roth
2017-10-26 23:30 ` [Qemu-devel] [PATCH 1/6] qga: group agent init/cleanup init separate routines Michael Roth
2017-10-26 23:30 ` [Qemu-devel] [PATCH 2/6] qga: hang GAConfig/socket_activation off of GAState global Michael Roth
2017-10-26 23:30 ` [Qemu-devel] [PATCH 3/6] qga: move w32 service handling out of run_agent() Michael Roth
2017-10-26 23:30 ` [Qemu-devel] [PATCH 4/6] qga: add --retry-path option for re-initializing channel on failure Michael Roth
2017-10-26 23:30 ` [Qemu-devel] [PATCH 5/6] qga-win: install service with --retry-path set by default Michael Roth
2017-10-26 23:30 ` Michael Roth [this message]
2017-10-26 23:38 ` [Qemu-devel] [PATCH 0/6] qga: add support for re-opening channel on error no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171026233054.21133-7-mdroth@linux.vnet.ibm.com \
--to=mdroth@linux.vnet.ibm.com \
--cc=daniel@daynix.com \
--cc=qemu-devel@nongnu.org \
--cc=sameeh@daynix.com \
--cc=yan@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).