From: "Daniel P. Berrange" <berrange@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-devel@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] build: allow automatic git submodule updates to be disabled
Date: Fri, 27 Oct 2017 08:10:03 +0100 [thread overview]
Message-ID: <20171027071003.GB24218@redhat.com> (raw)
In-Reply-To: <9b36faef-8798-9d3c-3803-c1800f3a4e2f@ozlabs.ru>
On Fri, Oct 27, 2017 at 03:10:17PM +1100, Alexey Kardashevskiy wrote:
> On 27/10/17 00:33, Philippe Mathieu-Daudé wrote:
> > On 10/26/2017 10:04 AM, Daniel P. Berrange wrote:
> >> Some people building QEMU use VPATH builds where the source directory is on a
> >> read-only volume. In such a case 'scripts/git-submodules.sh update' will always
> >> fail and users are required to run it manually themselves on their original
> >> writable source directory.
> >>
> >> While this is already supported, it is nice to give users a command line flag
> >> to configure to permanently disable automatic submodule updates, as it means
> >> they won't get hard to diagnose failures from git-submodules.sh at an arbitrary
> >> later date.
> >>
> >> This patch thus introduces a flag '--disable-git-update' which will prevent
> >> 'make' from ever running 'scripts/git-submodules.sh update'. It will still run
> >> the 'status' command to determine if a submodule update is needed, but when it
> >> does this it'll simply stop and print a message instructing the developer what
> >> todo. eg
> >>
> >> $ ./configure --target-list=x86_64-softmmu --disable-git-update
> >> ...snip...
> >>
> >> $ make
> >> GEN config-host.h
> >> GEN trace/generated-tcg-tracers.h
> >> GEN trace/generated-helpers-wrappers.h
> >> GEN trace/generated-helpers.h
> >> GEN trace/generated-helpers.c
> >> GEN module_block.h
> >>
> >> GIT submodule checkout is out of date. Please run
> >> scripts/git-submodule.sh update ui/keycodemapdb
> >> from the source directory checkout /home/berrange/src/virt/qemu
> >
> > Clean :)
> >
> >>
> >> make: *** [Makefile:31: git-submodule-update] Error 1
> >>
> >> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> >
> > Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
>
> What tree did you apply on top of? Does not apply for me :-/
Oh sorry, I forgot that it was on-top of my previously sent patch:
https://lists.gnu.org/archive/html/qemu-devel/2017-10/msg05054.html
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2017-10-27 7:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 13:04 [Qemu-devel] [PATCH] build: allow automatic git submodule updates to be disabled Daniel P. Berrange
2017-10-26 13:33 ` Philippe Mathieu-Daudé
2017-10-27 4:10 ` Alexey Kardashevskiy
2017-10-27 7:10 ` Daniel P. Berrange [this message]
2017-10-27 5:18 ` Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171027071003.GB24218@redhat.com \
--to=berrange@redhat.com \
--cc=aik@ozlabs.ru \
--cc=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).