qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, vsementsov@virtuozzo.com,
	qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
	Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [RFC PATCH v6 13/12] tweak test 83 verbosity
Date: Fri, 27 Oct 2017 12:45:46 +0200	[thread overview]
Message-ID: <20171027104546.8582-1-eblake@redhat.com> (raw)
In-Reply-To: <20171027104037.8319-1-eblake@redhat.com>

Commenting these two lines is enough to avoid the change to 083.out
in 12/12.  That is evidence that we may want these two lines to be
trace points rather than error messages; or maybe we really do like
the extra verbosity in the case of an unexpected communication break.

This patch does not meet coding guidelines, and I'm not proud enough
of it to give S-o-b, but I'm posting it for conversation.

---
 block/nbd-client.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/block/nbd-client.c b/block/nbd-client.c
index b44d4d4a01..e063b3fbc0 100644
--- a/block/nbd-client.c
+++ b/block/nbd-client.c
@@ -654,7 +654,8 @@ static int nbd_co_request(BlockDriverState *bs, NBDRequest *request,

     ret = nbd_co_receive_return_code(client, request->handle, &local_err);
     if (local_err) {
-        error_report_err(local_err);
+        assert(ret < 0);
+//        error_report_err(local_err);
     }
     return ret;
 }
@@ -682,7 +683,7 @@ int nbd_client_co_preadv(BlockDriverState *bs, uint64_t offset,
     ret = nbd_co_receive_cmdread_reply(client, request.handle, offset, qiov,
                                        &local_err);
     if (ret < 0) {
-        error_report_err(local_err);
+        //error_report_err(local_err);
     }
     return ret;
 }
-- 
2.13.6

  parent reply	other threads:[~2017-10-27 10:46 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-27 10:40 [Qemu-devel] [PATCH v6 00/12] nbd minimal structured read Eric Blake
2017-10-27 10:40 ` [Qemu-devel] [PATCH v6 01/12] nbd: Include error names in trace messages Eric Blake
2017-10-27 10:40 ` [Qemu-devel] [PATCH v6 02/12] nbd: Move nbd_errno_to_system_errno() to public header Eric Blake
2017-10-27 10:40 ` [Qemu-devel] [PATCH v6 03/12] nbd: Expose constants and structs for structured read Eric Blake
2017-10-27 10:40 ` [Qemu-devel] [PATCH v6 04/12] nbd/server: Report error for write to read-only export Eric Blake
2017-10-27 10:40 ` [Qemu-devel] [PATCH v6 05/12] nbd/server: Simplify nbd_negotiate_options loop Eric Blake
2017-10-30 16:43   ` Vladimir Sementsov-Ogievskiy
2017-10-27 10:40 ` [Qemu-devel] [PATCH v6 06/12] nbd/server: Refactor zero-length option check Eric Blake
2017-10-30 17:22   ` Vladimir Sementsov-Ogievskiy
2017-10-30 20:11     ` Eric Blake
2017-10-30 20:46       ` Eric Blake
2017-10-27 10:40 ` [Qemu-devel] [PATCH v6 07/12] nbd: Minimal structured read for server Eric Blake
2017-10-30 17:30   ` Vladimir Sementsov-Ogievskiy
2017-10-27 10:40 ` [Qemu-devel] [PATCH v6 08/12] nbd/server: Include human-readable message in structured errors Eric Blake
2017-10-27 10:40 ` [Qemu-devel] [PATCH v6 09/12] nbd/client: refactor nbd_receive_starttls Eric Blake
2017-10-30 17:32   ` Vladimir Sementsov-Ogievskiy
2017-10-27 10:40 ` [Qemu-devel] [PATCH v6 10/12] nbd/client: prepare nbd_receive_reply for structured reply Eric Blake
2017-11-13 19:33   ` Eric Blake
2017-10-27 10:40 ` [Qemu-devel] [PATCH v6 11/12] nbd: Move nbd_read() to common header Eric Blake
2017-10-27 10:40 ` [Qemu-devel] [PATCH v6 12/12] nbd: Minimal structured read for client Eric Blake
2017-10-30 17:55   ` Vladimir Sementsov-Ogievskiy
2017-10-27 10:45 ` Eric Blake [this message]
2017-10-30 12:34   ` [Qemu-devel] [RFC PATCH v6 13/12] tweak test 83 verbosity Vladimir Sementsov-Ogievskiy
2017-10-30 13:00     ` Eric Blake
2017-10-30 18:01   ` Vladimir Sementsov-Ogievskiy
2017-10-27 10:59 ` [Qemu-devel] [PATCH v6 00/12] nbd minimal structured read no-reply
2017-10-27 14:59   ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171027104546.8582-1-eblake@redhat.com \
    --to=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).