Re: [Qemu-devel] drive_add: file names with spaces

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Eric Blake (eblake@redhat.com) wrote:
> On 10/28/2017 06:44 AM, Programmingkid wrote:
> > I'm trying to use an image file that has spaces in its file name (and sometimes in the path) to be used as a USB flash drive. When I try adding the image file using the drive_add command I see this error: drive_add: extraneous characters at the end of the line
> > 
> > I have tried using single and double quotes around the file name but this does not help. Is there a way to use files that have spaces in it's name with drive_add?
> 
> Not in HMP, which lacks quoting.  (Unless you want to patch HMP to learn
> quoting)

I think it's already got that code at least in some places.
monitor_parse_arguments calls get_str, and get_str understands " wrapped
arguments.

drive_add 1 "file=foo bar"

gives me:
Could not open 'foo bar': No such file or directory

so I think that's doing the right thing.

Dave

> But using spaces in filenames works fine in QMP.
> 
> -- 
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3266
> Virtualization:  qemu.org | libvirt.org
> 


--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK