From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47698) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e8kiS-00041O-IZ for qemu-devel@nongnu.org; Sun, 29 Oct 2017 06:21:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e8kiP-00047P-EY for qemu-devel@nongnu.org; Sun, 29 Oct 2017 06:21:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35812) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e8kiP-00046V-7s for qemu-devel@nongnu.org; Sun, 29 Oct 2017 06:21:13 -0400 Date: Sun, 29 Oct 2017 10:21:07 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20171029102106.GA2841@work-vm> References: <7CA6B03C-DFAA-4A15-9E33-E3FAD6647140@gmail.com> <38c3125f-b050-c0ba-282f-bc1e9e11d297@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <38c3125f-b050-c0ba-282f-bc1e9e11d297@redhat.com> Subject: Re: [Qemu-devel] drive_add: file names with spaces List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Programmingkid , "qemu-devel@nongnu.org qemu-devel" * Eric Blake (eblake@redhat.com) wrote: > On 10/28/2017 06:44 AM, Programmingkid wrote: > > I'm trying to use an image file that has spaces in its file name (and sometimes in the path) to be used as a USB flash drive. When I try adding the image file using the drive_add command I see this error: drive_add: extraneous characters at the end of the line > > > > I have tried using single and double quotes around the file name but this does not help. Is there a way to use files that have spaces in it's name with drive_add? > > Not in HMP, which lacks quoting. (Unless you want to patch HMP to learn > quoting) I think it's already got that code at least in some places. monitor_parse_arguments calls get_str, and get_str understands " wrapped arguments. drive_add 1 "file=foo bar" gives me: Could not open 'foo bar': No such file or directory so I think that's doing the right thing. Dave > But using spaces in filenames works fine in QMP. > > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3266 > Virtualization: qemu.org | libvirt.org > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK